[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] xen/arm: Preserve host GIC #interrupt-cells for Dom0


  • To: Kuan-Wei Chiu <visitorckw@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: "Orzel, Michal" <michal.orzel@xxxxxxx>
  • Date: Tue, 17 Nov 2026 12:53:09 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WA/wKhPAvHl3N0cOfaqerOdHIK62tQkvqiNrFpqtZJE=; b=vexrpKg4OzBmTrub/AeLIy60WZ0mOfHJ4W8+HByPGjKYQcYjJNttd39EaPIbRUpVjFlV8K7ZGWJNsmkYKcKHrmkRwNwBTaQZv6z4tt/gle7Vq0wcHoQK8i945NM+d8lU7DDh2Pw+8THEnPLOlMs4hmmtft3S0TnLT8CZuFSuS1NCAb3fxJJ5IV+YW1lA55EtKyS9X9S8py6qP6yiagLLBh1796T+ENSTNqs7kveWHllbh6wr3SGj4XxYnxlMgzxRNTwL0DeafsdNAuJvOgYKd8ab7gr60hI1+vC7zu7VUVqQb0T9Wh7dcTm6Sp7pPbBFaoXdyaJ0yPBL/h7uyBuPrA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HpCP7lRA9shM44NEHh0A7PKesO7dxQdw4ecgU7trpy73Zu0BWPclkG9yhoNvTzxXrrjs4/Mumg5IGVDN93fYCH8aTqyLPEB3o7d+kfMSXqaDyIVpiskFtG0zwt+fpyKOjtY4rY0Ukh6Gx7hn0mtR1ZEB9mTBjDmEVIGuwPcCEdEZzCgaJr9GaAGv+LPI1nVlz6BRWsHK910CSvoAW462sQ7pb16PTBLPGuhPyFGUF3LEuYhJBAX8aKd+HnZChw57wH/1W0SMrEjQNhxvkqlQLLDuo2xKMUo95HJVcdyc3MfwsgV2RJSJjbKQXWE+enk1JRQHfP3QppWbsdeUBO20Qg==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Cc: <sstabellini@xxxxxxxxxx>, <julien@xxxxxxx>, <bertrand.marquis@xxxxxxx>, <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Tue, 17 Nov 2026 11:53:30 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 17-Nov-26 08:39, Kuan-Wei Chiu wrote:
> Xen copies device interrupt properties from the host device tree to
> Dom0, but hardcodes #interrupt-cells to 3 in make_gic_node() and
> fdt_property_interrupts(). On GICv3 platforms where the host uses 4
> cells, Dom0 parses the copied specifiers as 3 cells each and fails to
> set up device interrupts.
> 
> Propagate #interrupt-cells from the host GIC node in make_gic_node()
> and pad Dom0 interrupt specifiers with trailing zero cells in
> fdt_property_interrupts().
> 
> Signed-off-by: Kuan-Wei Chiu <visitorckw@xxxxxxxxx>
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---
> Changes in v2:
> - Add a comment in fdt_property_interrupts() explaining why only the
> hardware domain preserves the host GIC's #interrupt-cells and that
> extra cells beyond 3 are zero-padded.
> 
>  xen/arch/arm/domain_build.c | 37 ++++++++++++++++++++++++++++++++++---
>  1 file changed, 34 insertions(+), 3 deletions(-)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 606e85818e..d5bb895a6e 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -654,12 +654,37 @@ static int __init fdt_property_interrupts(const struct 
> kernel_info *kinfo,
>                                            unsigned int num_irq)
>  {
>      int res;
> +    uint32_t intrcells = ARRAY_SIZE(intr[0]);
> +    void *val;
> +    unsigned int i, stride;
>  
> -    res = fdt_property(kinfo->fdt, "interrupts",
> -                       intr, sizeof(intr[0]) * num_irq);
> +    /*
> +     * Only the hardware domain preserves the host GIC's #interrupt-cells,
> +     * since its device interrupt properties are copied from the host DT;
> +     * domUs always use a 3-cell virtual GIC. Any extra cells beyond the
> +     * 3-cell specifier, such as the GICv3 PPI affinity partition, are
> +     * zero-padded.
> +     */
> +    if ( is_hardware_domain(kinfo->bd.d) )
> +    {
> +        const struct dt_device_node *gic = dt_interrupt_controller;
> +
> +        if ( !dt_property_read_u32(gic, "#interrupt-cells", &intrcells) )
> +            return -FDT_ERR_XEN(ENOENT);
Blank line here.

> +        if ( intrcells < ARRAY_SIZE(intr[0]) )
> +            return -FDT_ERR_XEN(ERANGE);
> +    }
> +
> +    stride = intrcells * sizeof(intr[0][0]);
> +    res = fdt_property_placeholder(kinfo->fdt, "interrupts",
> +                                   stride * num_irq, &val);
>      if ( res )
>          return res;
>  
> +    memset(val, 0, stride * num_irq);
Blank line here.

> +    for ( i = 0; i < num_irq; i++ )
> +        memcpy((uint8_t *)val + i * stride, intr[i], sizeof(intr[0]));
> +
>      res = fdt_property_cell(kinfo->fdt, "interrupt-parent",
>                              kinfo->phandle_intc);
>  
> @@ -1320,6 +1345,7 @@ static int __init make_gic_node(const struct domain *d, 
> void *fdt,
>      int res = 0;
>      const void *addrcells, *sizecells;
>      u32 addrcells_len, sizecells_len;
> +    uint32_t intrcells;
>      const char *name;
>  
>      /*
> @@ -1370,7 +1396,12 @@ static int __init make_gic_node(const struct domain 
> *d, void *fdt,
>              return res;
>      }
>  
> -    res = fdt_property_cell(fdt, "#interrupt-cells", 3);
> +    if ( !dt_property_read_u32(gic, "#interrupt-cells", &intrcells) )
> +        return -FDT_ERR_XEN(ENOENT);
Blank line here.

With that my tag stands. Can be fixed on commit.

~Michal




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.