[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] x86emul: Zero-extend unsigned 8-bit immediates when decoding


  • To: jbeulich@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Stephen Cheng <stephen.cheng@xxxxxxxxxx>
  • Date: Tue, 17 Nov 2026 16:53:56 +0800
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LmiqgiDYFoxSjOtyyJqsxA3hVoaD6n7O8Po7+IjXIe0=; b=AynqoV7X2aIBXcLnI/mufi7ve+tzTOQJq24dMFWDwJjITNqWYFh/47FPib90h91d9eqBD6gxXQ8TMud8y/toj2fr7t+HkFgbNIUi6DiQt8SA3IoTzq6P3wW0jvT9txA5o+domTl1FqOVvrIYWd4k20PpVMRS1r23APAYMagtPfk0Cf0u0BwpEeyYI70XDCt4nRwNW1FaU3JWC386Ggah/JMN+C5OeY1gSnzyA/8YKYgghnADwWn9OEZk4WHb0Pm+23u4Pgci0RJ67zr+z8uf3jfrPiCMl+fChnfND2U3SZhpPAtaMfLJdU6z+I3h3NvhYcUcWse3+msoU6q0YGpjTg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ndXFZiS22AeRqmunO/F4e5HmH0Ij1GI8sT+4No4aYs0he8FRoi5+Ne37CfDkQ6PCUdhSx3Ce27vu28OklymubVsY69yyeEIkKPXTrutkzOEoc7s5NffCbLRjiH0bzGQ7577/4ccRddqKZgtwCX5ZX1pliL8VYad5wzk44VBKjDnYlyDxebZ8CVVBEAxCc4/6pjGjl02SFAtXZD7AiK37NZavx1yAMTdVTx73yk3Cvpl+AFdvN4q1vkgQ8lHvOz797+BTHqQYljGg/YWwoQWWziic+agqAYiLq0zgMQ0LDxUldjF5XjCLWk3zLVO4Lg24mblcutMYDJd5oMYLf/oMPQ==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: ross.lagerwall@xxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, roger@xxxxxxxxxxxxxx, teddy.astie@xxxxxxxxxx, Stephen Cheng <stephen.cheng@xxxxxxxxxx>
  • Delivery-date: Tue, 17 Nov 2026 08:54:34 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 17.11.2026 09:25, Jan Beulich wrote:
> I think I'll adjust this comment slightly: For VPROTx one can look at the
> immediate as both signed and unsigned: "When the count value is negative,
> bits are rotated to the right". I.e. I'll do s/are/can be viewed as/.

Thanks for the review. That's fine with me.

> Would you further be up to following up with another, smaller patch
> dealing with a similar issue?

Yes, I can do that. I'll start with XOP0A and then look at the other
cases you mention.

Stephen



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.