[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC v3 11/44] failfs: use fc_init_pseudo()
- To: Christian Brauner <brauner@xxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx
- From: Alexander Mikhalitsyn <alex@xxxxxxxxxxxx>
- Date: Tue, 17 Nov 2026 09:26:42 +0100
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20260707 header.d=amutable-com.20260707.gappssmtp.com header.i="@amutable-com.20260707.gappssmtp.com" header.h="MIME-Version:User-Agent:Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID"
- Cc: Jann Horn <jannh@xxxxxxxxxx>, Chris Mason <mason@xxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, driver-core@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, bpf@xxxxxxxxxxxxxxx, linux-security-module@xxxxxxxxxxxxxxx, selinux@xxxxxxxxxxxxxxx, apparmor@xxxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, fuse-devel@xxxxxxxxxxxxxxx, linux-efi@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, Amir Goldstein <amir73il@xxxxxxxxx>, linux-erofs@xxxxxxxxxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx, Chris Down <chris@xxxxxxxxxxxxxx>
- Delivery-date: Tue, 17 Nov 2026 08:26:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, 2026-11-16 at 12:04 +0100, Christian Brauner wrote:
> Initialize failfs as a pseudo filesystem instead of raising
> SB_I_NOEXEC and SB_I_NODEV by hand. This adds SB_I_PSEUDO.
>
> Reviewed-by: Jan Kara <jack@xxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Chris Down <chris@xxxxxxxxxxxxxx>
Reviewed-by: Alexander Mikhalitsyn <alex@xxxxxxxxxxxx>
> Signed-off-by: Christian Brauner (Amutable) <brauner@xxxxxxxxxx>
> ---
> fs/failfs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/failfs.c b/fs/failfs.c
> index 437cdc981c2de..f03334f361c0e 100644
> --- a/fs/failfs.c
> +++ b/fs/failfs.c
> @@ -3,6 +3,7 @@
> #include <linux/fs.h>
> #include <linux/fs/super_types.h>
> #include <linux/fs_context.h>
> +#include <linux/pseudo_fs.h>
> #include <linux/fs_struct.h>
> #include <linux/magic.h>
> #include <linux/mount.h>
> @@ -132,7 +133,7 @@ static int failfs_init_fs_context(struct
> fs_context *fc)
> fc->ops = &failfs_context_ops;
> fc->global = true;
> fc->sb_flags |= SB_NOUSER;
> - fc->s_iflags |= SB_I_NOEXEC | SB_I_NODEV;
> + fc_init_pseudo(fc);
> return 0;
> }
>
|