[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v14 04/15] xen/percpu: defer freeing per-CPU areas after resume failures


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Mykola Kvach <Mykola_Kvach@xxxxxxxx>
  • Date: Tue, 17 Nov 2026 01:04:35 +0000
  • Accept-language: en-US, uk-UA
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OO5X92yC8Ivno7ygApMFKN0/d3ZxqY23jb0TxLrwvu8=; b=TIInkZIUA9M4wAD2S9syvzoE26LFNpYJYhouAGFWXCmLqMxpJA+jZx23E82C4SqOHwd3r0MQAKOzoXi7lWkRkAopZdig6kUyb3ncrcZaDSYH7YZM8VHpU+eUAZZTT0ExcYmCK1CJhto9iGiUUwKtM/JHI9KamzI7MG9Yc6NpfS46yoWGCK6UXK/4beUk4kCA2u0eVfSXC6f8JB6fObeccaznvC0KCiS9j2bc20UB6lhocPJCm1A5PcZxu88oDmW50SnVqkfrcCKWwV5hYCfqEKuhuTPOdkUd6H5c6tcaNo50lYOoXBphvgNZVjiqxVhi+Z9UuqWDKnT8kAu8q/miag==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xuMEAEQpD1mVBXgstzkFtUN8GdbVg4f4SWWfjiykfyqFmHkloJydU/4S0lWo2ct9dND75vn8rrPrWugNurxISp3G6q36pSlgaYfc3j2SWsr46dZbfOuaNfZYQS/WrJH+G4HxqakIbT1kWLiT10yEnQeRbq9vQprF8u727gnIrVRoN3ZHzwOeB0noc0yj+VFpN56ZvOAfp4V74KwjRnl7YZr+Q83QClzKIVz/jhtcJ741l6yxr3cov8l2AcdTGVxPar8DVq3UoyvMnDPO732Md9S1OtJyjgwJjDJ+O4xwrxK5F1ZXspfv9XII+2bs4vVWbxsLwQzw88QCzT8o3mtltQ==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
  • Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
  • Cc: Mykola Kvach <Mykola_Kvach@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Tue, 17 Nov 2026 01:04:41 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHddi+cZOjwQapHtE2XhAKyWGxBnQ==
  • Thread-topic: [PATCH v14 04/15] xen/percpu: defer freeing per-CPU areas after resume failures

When a CPU fails to come back during system resume, cpu_up() sends
CPU_UP_CANCELED. After trying the other CPUs, enable_nonboot_cpus()
sends CPU_RESUME_FAILED for the same CPU.

On architectures which do not park offline CPUs, both notifications
queue free_percpu_area(). The release metadata, including the rcu_head,
is stored in that CPU's per-CPU area. The first callback may already
have freed the area when the second notification arrives, or the same
rcu_head may be queued twice. The CPU_RESUME_FAILED callbacks also need
the area to clean up timers and CPU-pool state.

Skip the per-CPU release for CPU_UP_CANCELED during resume. Let
CPU_RESUME_FAILED release the area after the other cleanup callbacks.

This prepares the common code for Arm system suspend. x86 parks offline
CPUs, so the per-CPU notifier does not call free_percpu_area() for either
CPU_UP_CANCELED or CPU_RESUME_FAILED.

Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
---
Changes in V14:
- Clarify that x86 skips free_percpu_area() for CPU_UP_CANCELED and
  CPU_RESUME_FAILED.
- Remove the blank line after fallthrough. No functional change.

Changes in v13:
- New patch.
---
 xen/common/percpu.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/xen/common/percpu.c b/xen/common/percpu.c
index f180f37253..757de111db 100644
--- a/xen/common/percpu.c
+++ b/xen/common/percpu.c
@@ -82,6 +82,14 @@ static int cf_check cpu_percpu_callback(
         break;
 
     case CPU_UP_CANCELED:
+        /*
+         * On resume, CPU_RESUME_FAILED is sent after all CPUs have been
+         * tried. Keep the area alive for its cleanup callbacks and let
+         * that notification release it.
+         */
+        if ( system_state == SYS_STATE_resume )
+            break;
+        fallthrough;
     case CPU_DEAD:
     case CPU_RESUME_FAILED:
         if ( !park_offline_cpus && system_state != SYS_STATE_suspend )
-- 
2.53.0

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.