[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 07/26] emul/ns16x50: implement IER/IIR registers
- To: dmukhin@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Date: Mon, 16 Nov 2026 17:59:32 +0100
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20260707 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID"
- Cc: andrew.cooper3@xxxxxxxxxx, anthony.perard@xxxxxxxxxx, jbeulich@xxxxxxxx, julien@xxxxxxx, michal.orzel@xxxxxxx, roger@xxxxxxxxxxxxxx, sstabellini@xxxxxxxxxx, xakep.amatop@xxxxxxxxx, dmukhin@xxxxxxx
- Delivery-date: Mon, 16 Nov 2026 16:59:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11/11/26 8:47 PM, dmukhin@xxxxxxxx wrote:
From: Denis Mukhin <dmukhin@xxxxxxxx>
Add interrupt enable register emulation (IER) and interrupt identity
reason (IIR) register emulation to the I/O port handler.
Also add routines for asserting/deasserting the virtual ns16x50
interrupt line as a dependent on IIR code. Add vPIC handling (HVM).
Latch the interrupt line state to avoid poke ns16x50_irq_check() on
every I/O register access.
ns16x50_irq_check() is still called on every access; what the latch
avoids is calling hvm_isa_irq_{,de}assert() when the line level hasn't
changed. Maybe "Latch the line state, so that vPIC is only told about
level changes"
Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
---
xen/common/emul/vuart/ns16x50.c | 112 ++++++++++++++++++++++++++++++++
1 file changed, 112 insertions(+)
diff --git a/xen/common/emul/vuart/ns16x50.c b/xen/common/emul/vuart/ns16x50.c
index 2371aa32d03f..7c5cdc99cfa7 100644
--- a/xen/common/emul/vuart/ns16x50.c
+++ b/xen/common/emul/vuart/ns16x50.c
@@ -88,6 +88,7 @@ struct vuart_ns16x50 {
const char *name; /* Device name */
spinlock_t lock; /* Protection */
struct xencons_interface cons; /* Emulated RX/TX FIFOs */
+ bool irq_asserted; /* IRQ line status */
};
static inline void ns16x50_lock_init(struct vuart_ns16x50 *vdev)
@@ -113,6 +114,101 @@ static inline void ns16x50_unlock(struct vuart_ns16x50
*vdev,
spin_unlock(&vdev->lock);
}
+static bool cf_check ns16x50_iir_check_lsi(const struct vuart_ns16x50 *vdev)
+{
+ return false;
+}
+
+static bool cf_check ns16x50_iir_check_rda(const struct vuart_ns16x50 *vdev)
+{
+ return false;
+}
+
+static bool cf_check ns16x50_iir_check_thr(const struct vuart_ns16x50 *vdev)
+{
+ return false;
+}
+
+static bool cf_check ns16x50_iir_check_msi(const struct vuart_ns16x50 *vdev)
+{
+ return false;
+}
+
+/*
+ * Get the interrupt identity reason.
+ *
+ * IIR is re-calculated once called, because ns16x50 always reports high
+ * priority events first.
+ */
+static uint8_t ns16x50_iir_get(const struct vuart_ns16x50 *vdev)
+{
+ /*
+ * Interrupt identity reasons by priority.
+ * NB: high priority are at lower indexes below.
+ */
+ static const struct {
+ bool (*check)(const struct vuart_ns16x50 *vdev);
+ uint8_t ier;
+ uint8_t iir;
+ } iir_by_prio[] = {
+ [0] = { ns16x50_iir_check_lsi, UART_IER_ELSI, UART_IIR_LSI },
+ [1] = { ns16x50_iir_check_rda, UART_IER_ERDAI, UART_IIR_RDA },
+ [2] = { ns16x50_iir_check_thr, UART_IER_ETHREI, UART_IIR_THR },
+ [3] = { ns16x50_iir_check_msi, UART_IER_EMSI, UART_IIR_MSI },
+ };
The priority order matches the 16550 (LSI > RDA > THRE > MSI). This
costs up to four indirect calls on every register access, though, and
each check is a one-liner. A plain sequence of ifs would be shorter,
avoid the cf_check annotations, and read just as well:
if ( (ier & UART_IER_ELSI) && (regs[UART_LSR] & UART_LSR_MASK) )
iir = UART_IIR_LSI;
else if ( (ier & UART_IER_ERDAI) && !ns16x50_fifo_rx_empty(vdev) )
iir = UART_IIR_RDA;
...
I am not going to insist on that probably it isn't really big cost...
+ const uint8_t *regs = vdev->regs;
+ uint8_t iir = 0;
+ unsigned int i;
+
+ for ( i = 0; i < ARRAY_SIZE(iir_by_prio); i++ )
+ {
+ if ( (regs[UART_IER] & iir_by_prio[i].ier) &&
+ iir_by_prio[i].check(vdev) )
+ break;
+
+ }
Nit: stray blank line before the closing brace.
+ if ( i == ARRAY_SIZE(iir_by_prio) )
+ iir |= UART_IIR_NOINT;
+ else
+ iir |= iir_by_prio[i].iir;
+
+ if ( regs[UART_FCR] & UART_FCR_ENABLE )
+ iir |= UART_IIR_FE;
+
+ return iir;
+}
+
+/*
+ * Assert/deassert virtual ns16x50 interrupt line.
+ */
Nit: the comment should be like /* ... */ here.
+static void ns16x50_irq_check(struct vuart_ns16x50 *vdev)
+{
+ const struct vuart_info *info = vdev->info;
+ struct domain *d = vdev->owner;
+ uint8_t iir = ns16x50_iir_get(vdev);
+ bool asserted = !(iir & UART_IIR_NOINT);
+
+ if ( asserted == vdev->irq_asserted )
+ return;
+
+ vdev->irq_asserted = asserted;
+
+ if ( has_vpic(d) )
+ {
+ if ( asserted )
+ hvm_isa_irq_assert(d, info->irq, vioapic_get_vector);
The return value (the vector) is ignored, so the get_vector callback
isn't needed: the other callers that don't use it (rtc.c, pmtimer.c,
dm.c) pass NULL. But I am not x86 person so probably I am missing something.
+ else
+ hvm_isa_irq_deassert(d, info->irq);
+ }
+ else
+ ASSERT_UNREACHABLE();
More generally, everything below the latch is x86-specific (has_vpic(),
hvm_isa_irq_{,de}assert(), and in 21/26 has_vioapic() and the
edge-only hvm_ioapic_assert()), while this is common code. The common
part only needs to say "the line is now high/low"; I'd put that behind
a single per-arch hook, e.g.
void vuart_arch_set_irq_level(struct domain *d, unsigned int irq,
bool level);
implemented for x86 with the vPIC/vIOAPIC logic above.
+
+ ns16x50_debug(vdev, "IRQ#%d IIR %#02x %s\n",
Nit: info->irq is unsigned (%u), and %#02x doesn't pad: the 0x prefix
counts towards the width, so it'd be %#04x.
+ info->irq,
+ iir,
+ asserted ? "assert" : "deassert");
+}
+
/*
* Emulate 8-bit write access to ns16x50 register.
*/
@@ -143,6 +239,10 @@ static int ns16x50_io_write8(
regs[NS16X50_REGS_NUM + UART_DLM] = val;
}
/* DLAB=0 */
+ else
+ {
+ regs[UART_IER] = val & UART_IER_ALL_INTR;
+ }
Nit: no braces around a single statement.
break;
/* NB: Firmware (e.g. OVMF) may rely on SCR presence. */
@@ -155,6 +255,8 @@ static int ns16x50_io_write8(
break;
}
+ ns16x50_irq_check(vdev);
+
return rc;
}
[...]
@@ -398,6 +507,7 @@ static void ns16x50_reset(struct vuart_ns16x50 *vdev)
const uint16_t divisor = (UART_CLOCK_HZ / 115200) >> 4;
memset(vdev->regs, 0, sizeof(vdev->regs));
+ vdev->irq_asserted = false;
/* NB: report 115200 baud rate. */
vdev->regs[NS16X50_REGS_NUM + UART_DLL] = divisor & UINT8_MAX;
@@ -428,6 +538,8 @@ static int ns16x50_init(void *arg)
ns16x50_reset(vdev);
+ ns16x50_irq_check(vdev);
+
After the reset IER is 0 and irq_asserted is false, so this returns
early. It's harmless, but it isn't needed.
return 0;
}
~ Oleksii
|