[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v13 05/14] xen/arm: gic-v3: Implement GICv3 suspend/resume functions


  • To: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • From: Mykola Kvach <xakep.amatop@xxxxxxxxx>
  • Date: Mon, 16 Nov 2026 14:15:57 +0200
  • Arc-authentication-results: i=1; mx.google.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=+/3pC1DOOT8boafXwN481xBar6gYaxUnO1VQTNAiNII=; fh=mTziSQThFeeOYTGpAiM5auKHF7P6xsZ+3MZNB61wh2Y=; b=OLhFgTNiAT1IgfzWE6BStsd41IfGTvp14HAnRsqgXFukBYdpOeB/Rcl2CrqfevkUPy A5n7pY231GUmDmwlvWRHvsrr+9+TteGgp7z/tEV+kkuHYylBiM2XxA1z4dGXX/EE1DuD 02em6zgdUzYbmQMrbRpdjpOOqZ5BXdTkmA2BbHTgAl4pIQzKQyRH2QbXDbLcvnafwSUJ Yk86EsL9ar/5n26TZZwR4pjYPX261CpOOt7gbfaWUhzviMi/bfCpuEu2kSNgcCktil6F MkF28G2PFoHd7p5rS07YW2lH2+7c6zoqU5ytemHv4lvgm0UuWQOHe2YPAvMEIk1MtysL GsvA==; darn=lists.xenproject.org
  • Arc-seal: i=1; a=rsa-sha256; t=1794831369; cv=none; d=google.com; s=arc-20260327; b=bUQ/DHLsaq7VaAuQc7gW/BkdX51PjBy0pY/jBhR5H5Jqz4ysY9L2FT7nipyBoCyEY9 WGqtHH3c6XmmZvW0PZH9ViIYUPWiL0XPJJ6g8o7mS5yM5bU3jqSwoahRzExz5cFahrFX 0RNqvN5WZrqsQ11grsOvqw1JDNf+ir/04cl9SaImAupS3r6lVc5/QGCIK9N2+eo0ZYvg ov82cuo5oi5i0OO0kBtJuyPpZoyTfWqGo4I8gxs88cUcKDyn2NLYUN1O5YN0bqPONggS 72cJ4Gggr9NQBygoFrLmuECWnf6gHbmGb50SU2QfYu5Od/2BrlZxAWocTb7qKdl+Ln6+ Pl+A==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20260707 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version"
  • Cc: Mykola Kvach <mykola_kvach@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Mon, 16 Nov 2026 12:16:24 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi Bertrand,

Thanks for the review.

On Tue, Nov 10, 2026 at 4:49 PM Bertrand Marquis
<Bertrand.Marquis@xxxxxxx> wrote:
>
> Hi Mykola,
>
> > On 27 Oct 2026, at 22:05, Mykola Kvach <mykola_kvach@xxxxxxxx> wrote:
> >
> > System suspend may lead to a state where GIC would be powered down.
> > Therefore, Xen should save/restore the context of GIC on suspend/resume.
> >
> > Note that the context consists of states of registers which are
> > controlled by the hypervisor. Other GIC registers which are accessible
> > by guests are saved/restored on context switch.
> >
> > Before continuing suspend, also verify that the physical CPU interface
> > has no Group 1 active-priority state left. Use ICC_CTLR_EL1.PRIbits to
> > decide which ICC_AP1R<n>_EL1 registers are implemented, so Xen does not
> > read an unimplemented AP1R register.
> >
> > Have gicv3_suspend() panic if the Redistributor does not set
> > GICR_WAKER.ChildrenAsleep before the timeout. Clearing ProcessorSleep
> > while ChildrenAsleep is still zero is UNPREDICTABLE, so Xen cannot safely
> > undo this transition and restore the CPU interface. Keep error reporting
> > in gicv3_disable_redist(), including the CPU.
> >
> > Check active priorities before disabling the CPU and virtual interfaces,
> > while local IRQs are masked. Return directly on failure, without changing
> > the interfaces or requesting Redistributor sleep.
> >
> > Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
>
> Looks good to me with one nit:
> With your renaming to nr_block_irqs some lines are now 81 chars it seems.

Ack.

Best regards,
Mykola

>
> With that handled:
> Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>
> Cheers
> Bertrand
>
>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.