|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v13 05/14] xen/arm: gic-v3: Implement GICv3 suspend/resume functions
Hi Bertrand, Thanks for the review. On Tue, Nov 10, 2026 at 4:49 PM Bertrand Marquis <Bertrand.Marquis@xxxxxxx> wrote: > > Hi Mykola, > > > On 27 Oct 2026, at 22:05, Mykola Kvach <mykola_kvach@xxxxxxxx> wrote: > > > > System suspend may lead to a state where GIC would be powered down. > > Therefore, Xen should save/restore the context of GIC on suspend/resume. > > > > Note that the context consists of states of registers which are > > controlled by the hypervisor. Other GIC registers which are accessible > > by guests are saved/restored on context switch. > > > > Before continuing suspend, also verify that the physical CPU interface > > has no Group 1 active-priority state left. Use ICC_CTLR_EL1.PRIbits to > > decide which ICC_AP1R<n>_EL1 registers are implemented, so Xen does not > > read an unimplemented AP1R register. > > > > Have gicv3_suspend() panic if the Redistributor does not set > > GICR_WAKER.ChildrenAsleep before the timeout. Clearing ProcessorSleep > > while ChildrenAsleep is still zero is UNPREDICTABLE, so Xen cannot safely > > undo this transition and restore the CPU interface. Keep error reporting > > in gicv3_disable_redist(), including the CPU. > > > > Check active priorities before disabling the CPU and virtual interfaces, > > while local IRQs are masked. Return directly on failure, without changing > > the interfaces or requesting Redistributor sleep. > > > > Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx> > > Looks good to me with one nit: > With your renaming to nr_block_irqs some lines are now 81 chars it seems. Ack. Best regards, Mykola > > With that handled: > Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx> > > Cheers > Bertrand > >
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |