|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v1 2/2] pci/rcar: Add support for Gen5 PCI host
16.11.2026 10:40, Mykyta Poturai пишет: Hello Mykyta Add support for Renesas R-Car Gen5 PCI host controller. This includes updating the device tree match table to recognize the new compatible string "renesas,rcar-gen5-pcie6" and ensuring that the OSID registers are only initialized when they are supported by the hardware. NIT: It is not entirely precise, the code only skips the app range lookup and ioremap on Gen5. Nothing guards OSID initialisation. That is harmless, because only the IPMMU driver uses it and Gen5 uses SMMUv3. Gen5 hosts do not expose the "app" register range, so only look it up on Gen4. Signed-off-by: Mykyta Poturai <mykyta_poturai@xxxxxxxx> --- xen/arch/arm/pci/pci-host-rcar.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/pci/pci-host-rcar.c b/xen/arch/arm/pci/pci-host-rcar.c index 5f184d5ebc..87b3ccbc1c 100644 --- a/xen/arch/arm/pci/pci-host-rcar.c +++ b/xen/arch/arm/pci/pci-host-rcar.c @@ -17,6 +17,9 @@#define RCAR_DWC_VERSION 0x520A +#define RCAR_GEN4 4 Remark: The result of dw_pcie_host_probe() is not checked. On failure it returns an ERR_PTR ... + match = dt_match_node(rcar_pcie_dt_match, dev);+ ASSERT(match); NIT: To be honest, I am not entirely sure why this assert is here. I assume it was copied from existing code. As far as I understand, dt_match_node() cannot fail here, because the device was already matched to reach the probe...
... which dw_pcie_set_priv() then dereferences. This is pre-existing, so maybe better to fix it in prereq commit. As for the current commit: Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |