[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 4/4] x86: prefer shadow stack for producing call traces


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 16 Nov 2026 11:42:57 +0100
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID"
  • Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
  • Cc: Teddy Astie <teddy.astie@xxxxxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 16 Nov 2026 10:43:01 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 16.11.2026 11:32, Jan Beulich wrote:
> On 10.11.2026 14:15, Andrew Cooper wrote:
>> On 09/11/2026 1:09 pm, Jan Beulich wrote:
>>> +        for ( n = 0; (unsigned long)ptr & (PAGE_SIZE - sizeof(*ptr)); ++n )
>>> +        {
>>> +            unsigned long val = *ptr;
>>> +
>>> +            if ( is_active_kernel_text(val) || in_stub(val) )
>>> +            {
>>> +                /* Normal return address entry.  */
>>> +                printk("   [<%p>] C %pS\n", _p(val), _p(val));
>>> +                ++ptr;
>>> +            }
>>> +            else if ( !((val ^ (unsigned long)ptr) >>
>>> +                        (PAGE_SHIFT + STACK_ORDER)) )
>>> +            {
>>> +                if ( val & (sizeof(val) - 1) )
>>> +                {
>>> +                    /* Most likely a supervisor token. */
>>> +                    break;
>>> +                }
>>> +
>>> +                /*
>>> +                 * Ought to be a hypervisor interruption frame.  But don't
>>> +                 * (re)log the current frame's %rip.
>>> +                 */
>>> +                if ( n || ptr[1] != regs->rip )
>>> +                    printk("   [<%p>] E %pS\n", _p(ptr[1]), _p(ptr[1]));
>>
>> Ah - this n is the thing covering the fact that you didn't move to the
>> outer context originally.  Please do that and drop this.
> 
> Why would I duplicate the move-to-outer-context code (just below)? We may
> need to move between contexts more than once, after all.
> 
>> If we're going to start using E here, we should make the FRAME_POINTER
>> side match.
> 
> Perhaps, but not in this patch.
> 
>>   When printing something we've identified as a stub, we
>> ought to say "in stub" rather than leaving it as a raw number.
> 
> Can do, albeit like you said for the use of E above this then likely wants
> mirroring to normal frames as well, again not in this patch though. (At
> which point the #ifdef you complained about above would simply go away.)
> Will you be okay with
> 
>             if ( is_active_kernel_text(val) )
>             {
>                 /* Normal return address entry.  */
>                 printk("   [<%p>] C %pS\n", _p(val), _p(val));
>                 ++ptr;
>             }
>             else if ( in_stub(val) )
>             {
>                 /* Stub return address entry.  */
>                 printk("   [<%p>] C <stub>\n", _p(val));
>                 ++ptr;
>             }
>             else if ( ... )
> 
> ?

Hmm, something similar would then be needed for the E case as well. (In
fact the above should be extremely unlikely to take effect, as in the
middle of a stub there shouldn't normally occur anything other than
exceptions.)

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.