[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: vpl011: record the virq only once it is reserved
- To: Stefano Stabellini <stefano.stabellini@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Mon, 16 Nov 2026 10:15:00 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/mr0bP6bkLX247dxuec/Rng2W59iThAyc7t9N1pmBv4=; b=nXshC2SPZSiYmDSW/3BiIGECKfcCMHU691JZs7HrjVAKNCKdwAxXeIdDsDWISnRDl9ktkyq7sVQs9j8sGAoKAQddtDdB8y2KfwRCV4Thn6mkYFCpIPri1Cny8HfCqQrCvGtSNVG8fvB0kwaD5FL2hr8ZNK39Aivyu6Xs3MOgHHw8ftt/GskTHFzch+Y/tlO6Q5O6u5AFHnawrGHCYbRgvIvw2H0jOkO1dV7V+9NuQHJhwxh6t9CETLWughjtoItSQzVVW4alms+6dv9cDUydQaH90J8zJVfOqfOLH8BgXYnOX9hveraKB6LrizlKMVBF0RuyrBO/uXjH6G+7yHfQxg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=g82t2Pyy3DgISJU+F0XKm0wQXw4lGHbjCmYY1NAHmS2u9/rYJYqRhV9dn7lugAzbPP404qYt894aKmXjdUQ5bZkJ/5JHe02nIX+bzKIweNKktwN8pcCmbRvoYxhd8GzN/n8jRbi+Ba1rFY5TI18zIuQJSsAzPwx3lr0HkQqbk8RkaXBSykjW1KL+m9Emmkd9uXYBV2LRgslCxc8D9TpBnCYzYtjNyNtf6g8weSU9vXwaE/TvD3tqIRpCcPEULi2b8yBY6BdEpcQ87Nyajf3UPOl94JeDmfDsHavjUrtjffpoTNclzRniHQxLpdg7qhYFjW5KCE0ObNT0Htx+wPTHuQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 16 Nov 2026 09:15:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14-Nov-26 03:00, Stefano Stabellini wrote:
> domain_vpl011_init() sets vpl011->virq before vgic_reserve_virq() claims
> it, and both a refused reservation and a failed
> alloc_unbound_xen_event_channel() take the out1 error path into
> domain_vpl011_deinit(), which frees vpl011->virq. That clears the
> allocation bit of an interrupt the vPL011 never reserved, so an
> interrupt held by another user can be handed out a second time.
Who is the other user here? The virq is either GUEST_VPL011_SPI or the
Xen UART IRQ. libxl rejects a passthrough IRQ that matches the vpl011
SPI, dom0less reserves the vpl011 virq before passthrough and panics
on failure, and the Xen UART cannot be assigned. AFAICT there is no issue as of
today and this should be explained in the commit msg.
>
> Record the virq only after the reservation succeeds.
>
> Fixes: 08bbc1c02d38 ("xen/arm: vpl011: Fix domain_vpl011_init error path")
The SHA is wrong - unknown revision. That said, I think this should be
1ee1e4b0d1ff instead.
~Michal
|