[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 03/26] x86: fixup dependencies for asm/x86_emulate.h
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, dmukhin@xxxxxxxx
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 13 Nov 2026 08:20:57 +0100
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID"
- Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
- Cc: andrew.cooper3@xxxxxxxxxx, anthony.perard@xxxxxxxxxx, julien@xxxxxxx, michal.orzel@xxxxxxx, roger@xxxxxxxxxxxxxx, sstabellini@xxxxxxxxxx, xakep.amatop@xxxxxxxxx, dmukhin@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 13 Nov 2026 07:21:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12.11.2026 21:25, Oleksii Kurochko wrote:
>
>
> On 11/11/26 8:47 PM, dmukhin@xxxxxxxx wrote:
>> From: Denis Mukhin <dmukhin@xxxxxxxx>
>>
>> Add xen/bug.h so that asm/x86_emulate.h can be cleanly used if listed as
>> the first include in translation unit.
>
> It would help to say what is needed from it: x86emul_invpcid_aux() in
> x86_emulate/x86_emulate.h uses ASSERT(), which lives in xen/bug.h, and
> xen/lib.h no longer provides it.
>
> I haven't checked by do we really need then inclusion of xen/lib.h in
> x86_emulate.h? Won't it be enough to have only xen/bug.h as my
> understanding that the only reason for xen/lib.h is (was) ASSERT?
>
>>
>> Amends: 0a249bcb0279 ("x86: reduce dependencies on
>> x86_emulate/x86_emulate.h")
>
> I don't think that commit is where this comes from. A translation unit
> containing only #include <asm/x86_emulate.h> fails with "implicit
> declaration of function 'ASSERT'" both at 0a249bcb0279 and at its
> parent. The ASSERT() dependency got lost with 8de3afc0b402 ("xen: move
> BUG_ON(), WARN_ON(), ASSERT(), ASSERT_UNREACHABLE() to xen/bug.h"),
> which dropped xen/bug.h from xen/lib.h. Since the header wasn't
> self-contained before that either, I'd rather drop the tag than point
> it at 0a249bcb0279.
+1
A Fixes: tag would imo be appropriate only if there was active breakage
in the present tree (possibly only in some exotic configuration).
>> --- a/xen/arch/x86/include/asm/x86_emulate.h
>> +++ b/xen/arch/x86/include/asm/x86_emulate.h
>> @@ -13,6 +13,7 @@
>> #define __ASM_X86_X86_EMULATE_H__
>>
>> #include <xen/types.h>
>> +#include <xen/bug.h>
>
> Nit: alphabetical order (xen/bug.h first).
And then, with xen/lib.h dropped and ...
>> #include <xen/lib.h>
>> #include <asm/regs.h>
>> #include <asm/x86-defns.h>
... a blank line inserted in its place, we'll be fully style-conforming
here.
Jan
|
