Re: [PATCH v1 04/28] x86/hvm: avic: add domain state initialization

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 05/11/2026 1:33 am, dmukhin@xxxxxxxx wrote:
> diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
> index db81dad4b681..8b7bfed0049f 100644
> --- a/xen/arch/x86/hvm/svm/svm.c
> +++ b/xen/arch/x86/hvm/svm/svm.c
> @@ -2464,6 +2476,12 @@ static void __init print_svm_features(void)
>          printk(" - none\n");
>  }
>  
> +static void __init svm_avic_start(void)
> +{
> +    if ( !cpu_has_svm_avic || pv_shim )
> +        svm_avic_enable = false;
> +}
> +

arch/x86/hvm/svm/svm.c: In function ‘svm_avic_start’:
arch/x86/hvm/svm/svm.c:2480:31: error: ‘pv_shim’ undeclared (first use in this 
function)
 2480 |     if ( !cpu_has_svm_avic || pv_shim )
      |                               ^~~~~~~
arch/x86/hvm/svm/svm.c:2480:31: note: each undeclared identifier is reported 
only once for each function it appears in



But, you shouldn't care about pv_shim here at all.  By and large, shim
won't have CONFIG_HVM, but if someone has decided to make such a shim
and AVIC is in advertised in CPUID, then Xen should see about using it
just as on native.

~Andrew