[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v9 09/19] hw/usb/bus: Turn off the automatic hub by default
- To: "berrange@xxxxxxxxxx" <berrange@xxxxxxxxxx>, "junjie.cao@xxxxxxxxx" <junjie.cao@xxxxxxxxx>, "kraxel@xxxxxxxxxx" <kraxel@xxxxxxxxxx>, "marcandre.lureau@xxxxxxxxxx" <marcandre.lureau@xxxxxxxxxx>, "clg@xxxxxxxx" <clg@xxxxxxxx>, "junjie.cao@xxxxxxxxx" <junjie.cao@xxxxxxxxx>, Pierrick Bouvier <pierrick.bouvier@xxxxxxxxxxxxxxxx>, Peter Maydell <peter.maydell@xxxxxxxxxx>, Kane Chen <kane_chen@xxxxxxxxxxxxxx>, Philippe Mathieu-Daudé <philmd@xxxxxxxxxxxxxxxx>, Tyrone Ting <kfting@xxxxxxxxxxx>, Hao Wu <wuhaotsh@xxxxxxxxxx>, Zhao Liu <zhao1.liu@xxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Helge Deller <deller@xxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony@xxxxxxxxxxxxxx>, "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxx>, "open list:All patches CC here" <qemu-devel@xxxxxxxxxx>, "open list:ASPEED BMCs" <qemu-arm@xxxxxxxxxx>, "open list:X86 Xen CPUs" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jamin Lin <jamin_lin@xxxxxxxxxxxxxx>
- Date: Tue, 10 Nov 2026 07:28:32 +0000
- Accept-language: zh-TW, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m7Lwug8hOsF0j+JcduZ0RbghxZtyiG2nsDqjDex9dL8=; b=NnNaf3yrpLLNMua2HH3dJdEy51UY6j4E5cFMN4hQLyaRCXN5ZDblWuZyaXtiB3tUiJjdi8iAsVP63tqPqwPheLgMQ2kGCIbnvCOJD7vgZc3h8gSTsMsA2g84Cphb1kW/ulbol1Yy6I9cbuDL4gxHF1o3BBRvjecnOa7SzzsN75eyIblSbZ5RA6HjdUQmndGFb1nvzY7CydxuUVRWRXEhXdcMJYtZGKojAWM7/vhFfIJJoc7eCZauc4k+nWCt3W688wFyAdx31h/KTGeGPxZL1V953UY+6pKUoHZ+qlte9ao47m5+vOf8aJZPaV7k6pB2pu0708kVK0KVXfLQgC4X8A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vjEIUk7gr5NdP9G4kbxS2JDCi+Uq5/oSlD0YjB7w9vLWSHRyxlHUjF1cpNzqCZn+PXEyeMvn96UxKboTLJLxJFmJnDrvDK6R8Fy7Yhao5XbgggQY2ptbnxpSfTKri6Z14zZCxHvu9iQ0hCQvOAn6RxcLJhPMbmp97gMW165trMPbJMVgKxJFgugbrb2jp2Sjdd4gca6PJthHtEGD+ZYP4QjmpLfCoHNPHGR6PqR4X7FSM8ikCjVR1ZFMBlMpcycNpHvgbAyKPi76WYUDxhDrRDxemNsDgdY8oP8ZIpnUNkFJ68y8/p7f2a1GigSNd6KBFroTanfxoBB/Agz1mjVl4w==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=aspeedtech.com header.i="@aspeedtech.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com;
- Cc: Jamin Lin <jamin_lin@xxxxxxxxxxxxxx>, Troy Lee <troy_lee@xxxxxxxxxxxxxx>
- Delivery-date: Tue, 10 Nov 2026 07:28:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHdcOUWPslb2rn5lUiKJGyQMhqFzw==
- Thread-topic: [PATCH v9 09/19] hw/usb/bus: Turn off the automatic hub by default
Every bus creator now sets auto_hub from its own property, or clears
it outright, so the value usb_bus_new() leaves there is never read.
Drop the line. A new bus then has no hub unless its controller asks
for one.
Suggested-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>
Signed-off-by: Jamin Lin <jamin_lin@xxxxxxxxxxxxxx>
Reviewed-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
---
hw/usb/bus.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/usb/bus.c b/hw/usb/bus.c
index 92f67de4fe..cd587db892 100644
--- a/hw/usb/bus.c
+++ b/hw/usb/bus.c
@@ -92,7 +92,6 @@ void usb_bus_new(USBBus *bus, size_t bus_size,
qbus_set_bus_hotplug_handler(BUS(bus));
bus->ops = ops;
bus->busnr = next_usb_bus++;
- bus->auto_hub = true;
QTAILQ_INIT(&bus->free);
QTAILQ_INIT(&bus->used);
QTAILQ_INSERT_TAIL(&busses, bus, next);
--
2.43.0
|
