[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v9 07/19] hw/usb/xen-usb: Do not insert an automatic hub
- To: "berrange@xxxxxxxxxx" <berrange@xxxxxxxxxx>, "junjie.cao@xxxxxxxxx" <junjie.cao@xxxxxxxxx>, "kraxel@xxxxxxxxxx" <kraxel@xxxxxxxxxx>, "marcandre.lureau@xxxxxxxxxx" <marcandre.lureau@xxxxxxxxxx>, "clg@xxxxxxxx" <clg@xxxxxxxx>, "junjie.cao@xxxxxxxxx" <junjie.cao@xxxxxxxxx>, Pierrick Bouvier <pierrick.bouvier@xxxxxxxxxxxxxxxx>, Peter Maydell <peter.maydell@xxxxxxxxxx>, Kane Chen <kane_chen@xxxxxxxxxxxxxx>, Philippe Mathieu-Daudé <philmd@xxxxxxxxxxxxxxxx>, Tyrone Ting <kfting@xxxxxxxxxxx>, Hao Wu <wuhaotsh@xxxxxxxxxx>, Zhao Liu <zhao1.liu@xxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Helge Deller <deller@xxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony@xxxxxxxxxxxxxx>, "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxx>, "open list:All patches CC here" <qemu-devel@xxxxxxxxxx>, "open list:ASPEED BMCs" <qemu-arm@xxxxxxxxxx>, "open list:X86 Xen CPUs" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jamin Lin <jamin_lin@xxxxxxxxxxxxxx>
- Date: Tue, 10 Nov 2026 07:28:29 +0000
- Accept-language: zh-TW, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0i+dDbnhs/ipwjDDII73SF8lfh+KFUTrj5s7rxXYH0w=; b=wO8LGOJbGNrnpJnKLwW78CdjNcYZsgYegUmPl5IrNEBlavQpanVlpqWtkYLax4QzRjXIqE6KC+KtfI3pXiH9Z4u6eE/mNbEyvnQjCf9ISxG79hg7d7vNCZZ4QXq4xTLJledGloZACEdNffxDD82RdIANr6jQmGQ4y4Mb/ZHH4uK/MXJ47+KzyvouszbwWAwCAGqmSInefkshB1rZ5liLS8Rf9ywBcAs6WoLllVkOEzdknjsZ87q0fBuQjbaZFARhaPyEvHSF0ER6WhnVaowO0GfNAl+wCe/huOzSX0YkhFdvsKoJAvGec4YNtGKBzP9vRrchUuhClXYA7IcMZ4xBDw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ejoB3sk6/0WssDRQ8ZE7Wx3OYWS3v4xrByZ0Rt8QgsnNNsB/lJzMCu0U/DEIpxdT9ojUIvFhAejCMSacGqqPdVnSR4KPQ9wnKTGSp+HBvYySK2oqWb+BJ+zsX87i9D+dNv4pGHkx9d9MpmXt5Ek0j2CkpD5PIKikCueuV3hhMyKAr+LQ2E3lB8eJrUyALxCRPKa8LVn/5K1cHYd7GeZk5ASYwukUdaP5nU8Vbd4K/ZpVUruE9ZGVZhgQpGEH4glM1nG9rW/ffGYoBsRYnWdZkT08k8HGXRe4T+VSbuqG7+ZQ5vDfT5NeXMpVWnWyrsjm9yIaMkA8qSm3nOIs9WD6WQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=aspeedtech.com header.i="@aspeedtech.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com;
- Cc: Jamin Lin <jamin_lin@xxxxxxxxxxxxxx>, Troy Lee <troy_lee@xxxxxxxxxxxxxx>
- Delivery-date: Tue, 10 Nov 2026 07:28:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHdcOUVAdCkms4ACkaoU6ZRpD1Y9g==
- Thread-topic: [PATCH v9 07/19] hw/usb/xen-usb: Do not insert an automatic hub
xen-usb gives every device a port number. usb_claim_port() then uses
that port, and never reaches the automatic hub.
Set auto_hub to false. Every bus creator then sets the flag itself,
and usb_bus_new() can stop setting a default.
Suggested-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>
Signed-off-by: Jamin Lin <jamin_lin@xxxxxxxxxxxxxx>
Acked-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
---
hw/usb/xen-usb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/usb/xen-usb.c b/hw/usb/xen-usb.c
index caf9efbb77..5d1dbe6b1b 100644
--- a/hw/usb/xen-usb.c
+++ b/hw/usb/xen-usb.c
@@ -1023,6 +1023,7 @@ static void usbback_alloc(struct XenLegacyDevice *xendev)
usb_bus_new(&usbif->bus, sizeof(usbif->bus), &xen_usb_bus_ops,
DEVICE(xendev));
+ usbif->bus.auto_hub = false;
for (i = 0; i < USBBACK_MAXPORTS; i++) {
p = &(usbif->ports[i].port);
usb_register_port(&usbif->bus, p, usbif, i, &xen_usb_port_ops,
--
2.43.0
|
