Re: [PATCH 06/14] udf: convert mmap hook to mmap_prepare

[Jan Kara <jack@xxxxxxx>]

On Thu 05-11-26 21:05:37, Lorenzo Stoakes (ARM) wrote:
> Move from the deprecated mmap hook to the new mmap_prepare hook. The hook
> only updates the access time and sets the VMA operations.
> 
> Signed-off-by: Lorenzo Stoakes (ARM) <ljs@xxxxxxxxxx>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

I'll leave it for MM guys to merge this.
                                                                Honza

> ---
>  fs/udf/file.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/udf/file.c b/fs/udf/file.c
> index 02e9314818dc..d5e80c6cae96 100644
> --- a/fs/udf/file.c
> +++ b/fs/udf/file.c
> @@ -190,10 +190,10 @@ static int udf_release_file(struct inode *inode, struct 
> file *filp)
>       return 0;
>  }
>  
> -static int udf_file_mmap(struct file *file, struct vm_area_struct *vma)
> +static int udf_file_mmap_prepare(struct vm_area_desc *desc)
>  {
> -     file_accessed(file);
> -     vma->vm_ops = &udf_file_vm_ops;
> +     file_accessed(desc->file);
> +     desc->vm_ops = &udf_file_vm_ops;
>  
>       return 0;
>  }
> @@ -202,7 +202,7 @@ const struct file_operations udf_file_operations = {
>       .read_iter              = generic_file_read_iter,
>       .unlocked_ioctl         = udf_ioctl,
>       .open                   = generic_file_open,
> -     .mmap                   = udf_file_mmap,
> +     .mmap_prepare           = udf_file_mmap_prepare,
>       .write_iter             = udf_file_write_iter,
>       .release                = udf_release_file,
>       .fsync                  = simple_fsync,
> 
> -- 
> 2.56.0
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR