[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] IOMMU: record the flushes skipped under iommu_dont_flush_iotlb
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Luca Di Maio <luca@xxxxxxxxx>
- Date: Fri, 6 Nov 2026 09:03:22 +0100
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=edera.dev header.i="@edera.dev" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From"
- Cc: Luca Di Maio <luca@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Teddy Astie <teddy.astie@xxxxxxxxxx>
- Delivery-date: Fri, 06 Nov 2026 08:04:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 02/11/2026 17:54, Jan Beulich wrote:
> On 31.10.2026 11:55, Teddy Astie wrote:
>> Le 30/10/2026 à 17:53, Luca Di Maio a écrit :
>>> +DEFINE_PER_CPU(uint8_t, iommu_skipped_flush_flags);
>>
>> flush_flags in iotlb_flush is unsigned int in iommu_iotlb_flush(), so I
>> would use it here as well instead of uint8_t.
>
> +1
>
> Also see ./CODING_STYLE on the matter. If not unsigned int, the next choices
> would be unsigned short or unsigned char, not uint8_t.
Thanks for the review, Jan and Teddy.
I'll address your comments in upcoming v2.
L.
|
