[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v8 02/18] hw/usb/hcd-xhci: Add an auto-hub property and leave it off
- To: Junjie Cao <junjie.cao@xxxxxxxxx>
- From: Jamin Lin <jamin_lin@xxxxxxxxxxxxxx>
- Date: Fri, 6 Nov 2026 03:29:28 +0000
- Accept-language: zh-TW, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tXmZP/o22YPY7Nw2kfylYO7CV8zovobJxt4LFUh8yAw=; b=TVHKPPG/Zl5WBvSREpa8ZzgVyw+BMvxUab8i4P3qb9PvbALXdIXng65BYr0tVU0CWsKVE92pXquatCkKsRbmbJmwgW+oCyOShYYzGzeQXPzWWyVr9f3zb9OMm0vlumWSKet2VwB/yuHtyLJNP2a0Rx+Kh5f4EFbjOv4jK8IkFWawbf48/JDVY+T8GkwTMrE9QL5ol0TMPPETY8iIW4hoDSZi89RF9XgjKbdUlO0X46Wd9bpxJvAkQY+gjEAyBwPwEF+PB5ZaIQkSrBXkQFAMiTL5CBY/SbzZf2x6NEBTSYoay89yZQGi3cESbisB79i9KAqnTfMsQQjKWosZsD3XIA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=F+swJkAI4g9oFVIKF0u2bex4mRk5WKt9u2teZGIEmJG9sazBYlev46u2qdbTrf3opi+RI/zslKVjvurOrmFNwyLskKCsQ94KTkaXg82gJpSxnCLHliVPTvFeko+xSOARNK+0lUT6qKd0VcPD2rBCGjtXxF0SLC2jNSFtd36+u3zwj8Vvw1oIb3S8yjXIh4aDwjtjZwaMAtMBNn73bZ44Smsv/pzY8oAMl/SEWWRhanHSdwJJrGjmRP0mWTTYNcdaaj2i79G3t1b9XcP+zmfcdPZelnuGww2IcW3oTxivG/sylx6EL4v+YwC+1ZiHbmYUWk1TcatgbjuZpjpzRkFfYw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=aspeedtech.com header.i="@aspeedtech.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com;
- Cc: "kraxel@xxxxxxxxxx" <kraxel@xxxxxxxxxx>, "marcandre.lureau@xxxxxxxxxx" <marcandre.lureau@xxxxxxxxxx>, "clg@xxxxxxxx" <clg@xxxxxxxx>, "pierrick.bouvier@xxxxxxxxxxxxxxxx" <pierrick.bouvier@xxxxxxxxxxxxxxxx>, "peter.maydell@xxxxxxxxxx" <peter.maydell@xxxxxxxxxx>, Kane Chen <kane_chen@xxxxxxxxxxxxxx>, "philmd@xxxxxxxxxxxxxxxx" <philmd@xxxxxxxxxxxxxxxx>, "kfting@xxxxxxxxxxx" <kfting@xxxxxxxxxxx>, "wuhaotsh@xxxxxxxxxx" <wuhaotsh@xxxxxxxxxx>, "zhao1.liu@xxxxxxxxx" <zhao1.liu@xxxxxxxxx>, "richard.henderson@xxxxxxxxxx" <richard.henderson@xxxxxxxxxx>, "deller@xxxxxx" <deller@xxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "anthony@xxxxxxxxxxxxxx" <anthony@xxxxxxxxxxxxxx>, "edgar.iglesias@xxxxxxxxx" <edgar.iglesias@xxxxxxxxx>, Troy Lee <troy_lee@xxxxxxxxxxxxxx>, "qemu-devel@xxxxxxxxxx" <qemu-devel@xxxxxxxxxx>, "qemu-arm@xxxxxxxxxx" <qemu-arm@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 06 Nov 2026 03:29:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHdaqugzonZbCOsyEq5GblPuZWDarccaGeAgAP/C2A=
- Thread-topic: [PATCH v8 02/18] hw/usb/hcd-xhci: Add an auto-hub property and leave it off
> Subject: Re: [PATCH v8 02/18] hw/usb/hcd-xhci: Add an auto-hub property and
> leave it off
>
> Hi Jamin,
>
> On Mon, Nov 02, 2026 at 09:22:05AM +0000, Jamin Lin wrote:
> > Add auto-hub and leave it off. hw_compat_11_1 turns it on, so an older
> > machine type keeps the hub it has today and a guest saved by an older
> > QEMU still loads.
>
> Reran the migration check from v7: with pc-q35-11.1, a guest saved without
> the series loads on v8 with the hub in place, for qemu-xhci with four HID
> devices and for q35 -usb with six.
>
> But this missed the 11.2 soft freeze, so in 12.0 pc-q35-11.2 is an old machine
> type too, and hw_compat_11_1 (my suggestion on v7) doesn't cover it. Saved
> with pc-q35-11.2 on master, both cases fail on v8:
>
> Unknown section or instance '0000:00:01.0/4/usb-hub' 0
> Unknown section or instance '0000:00:1d.7/6/usb-hub' 0
>
> The entries from 02-05 want hw_compat_11_2 once the 12.0 machine types
> are in.
>
> Junjie
Hi Junjie, Marc-André, and Gerd,
Due to the QEMU code freeze and the planned 11.2 release in December, disabling
automatic hub creation while keeping migration compatibility with older QEMU
versions requires adding the property to hw_compat_11_2.
We need to wait until after the QEMU 11.2 release for the maintainers to add
hw_compat_11_2 to each machine type.
The USB redirection server is my original upstream goal, and I think this task
is independent of the automatic hub task.
So, I want to split the auto-hub changes into a separate prerequisite patch
series and send v9 after the QEMU 11.2 release.
The USB redirection server common protocol series still needs rework on the
device announcement and control transfer patches.
I will send v9 next week and mention that it requires the patch series that
disables automatic hub creation.
This way, we can continue testing and reviewing the USB redirection server
common protocol this month.(November)
"If you agree, I will send v9 next week. Otherwise, I will wait until after the
QEMU 11.2 release and then resend the full patch series as v9."
Thanks,
Jamin
|
