[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 03/28] x86/hvm: report SVM x2AVIC support


  • To: <dmukhin@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Thu, 5 Nov 2026 17:13:50 -0500
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=ford.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iymiZYmbNPUrd5MkefBw4xPHLXThoi9sY+cXvPrbQL0=; b=NFklqWhLQIX1sJshag76A34pmY+KQxEyiCeKPI0JYb/jKTrSOXLXATffeQ9GJIUMyvqFdNvKEK4ePWi5ooWYew3TJCZauIm5q/Tam4VJghR77CPFN1jp4PTZeFCkL8EZXenR0jfpasv7PkzLCKpvDh10RTyc/6rzoNU4yBaCVh5Ff5BQ7c5nT3w5q9cLR9QrNMtrniFmX4s5D5/e65V+PO7YN8jnNxMYNpT3PY3Trwijkply13pkm7NaTLLAhqgiJcP7rF9MJIgsQjTjOq/UuOj0rVD+L0t6YFklppRQyC7k8HcRaVC5mwqv7uGT+Q6AiKgiy/QD0F68YG1wYIbVeQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=i/tPqixAmM6zCUG4xjlXSAm/EIX0GZ2NzUU5WqXcUTlyMU8EkcBMp/2ivIjYqseAs+BX0LR5UO2Imc7cVKzdI0dxq+GmAwPTwtkYZP6cHUqE7X9q+cQYKoTa9EfLniFKmzntrQHWeTHZxm/ihXpvrlZaOmKFe4YeGYMAoIY27/8HJAme6LPiAliBd5OYXM1OeUdOuKS3pjp3InEJingJb4qps9MpzFHrifxLP/6HRjx7laiFFnEa6zE/jaMN5pF9ABFE4Lt30cKcW6GuDhbdwjBPibYg39HNn4lKztNoHxcf23ifYd2ywcvL7SF922IgEHXwILNyKPtjaLc0Ru9CMQ==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Cc: <andrew.cooper3@xxxxxxxxxx>, <jbeulich@xxxxxxxx>, <roger@xxxxxxxxxxxxxx>, <teddy.astie@xxxxxxxxxx>, <dmukhin@xxxxxxx>
  • Delivery-date: Thu, 05 Nov 2026 22:14:16 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2026-11-04 20:33, dmukhin@xxxxxxxx wrote:
From: Denis Mukhin <dmukhin@xxxxxxxx>

Report SVM AVIC support from CPUID Fn8000000A_EDX[X2AVIC](bit 18).

Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
---
  xen/arch/x86/hvm/svm/svm.c         | 1 +
  xen/arch/x86/include/asm/hvm/svm.h | 2 ++
  2 files changed, 3 insertions(+)

diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
index cf008a8acdf2..db81dad4b681 100644
--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -2457,6 +2457,7 @@ static void __init print_svm_features(void)
      P(cpu_has_svm_vnmi, "Virtual NMI");
      P(cpu_has_svm_bus_lock, "Bus Lock Filter");
      P(cpu_has_svm_avic, "Advanced Virtual Interrupt Controller");
+    P(cpu_has_svm_x2avic, "x2 Advanced Virtual Interrupt Controller");

Sorry, this ...

  #undef P
if ( !printed )
diff --git a/xen/arch/x86/include/asm/hvm/svm.h 
b/xen/arch/x86/include/asm/hvm/svm.h
index 0fc33f41b09d..292a9ee19b11 100644
--- a/xen/arch/x86/include/asm/hvm/svm.h
+++ b/xen/arch/x86/include/asm/hvm/svm.h
@@ -36,6 +36,7 @@ extern u32 svm_feature_flags;
  #define SVM_FEATURE_AVIC          13 /* Advanced Virtual Interrupt Controller 
*/
  #define SVM_FEATURE_VLOADSAVE     15 /* virtual vmload/vmsave */
  #define SVM_FEATURE_VGIF          16 /* Virtual GIF */
+#define SVM_FEATURE_X2AVIC        18 /* x2 Advanced Virtual Interrupt 
Controller */
  #define SVM_FEATURE_SSS           19 /* NPT Supervisor Shadow Stacks */
  #define SVM_FEATURE_SPEC_CTRL     20 /* MSR_SPEC_CTRL virtualisation */
  #define SVM_FEATURE_VNMI          25 /* Virtual NMI */
@@ -57,6 +58,7 @@ static inline bool cpu_has_svm_feature(unsigned int feat)
  #define cpu_has_pause_thresh  cpu_has_svm_feature(SVM_FEATURE_PAUSETHRESH)
  #define cpu_has_tsc_ratio     cpu_has_svm_feature(SVM_FEATURE_TSCRATEMSR)
  #define cpu_has_svm_avic      cpu_has_svm_feature(SVM_FEATURE_AVIC)
+#define cpu_has_svm_x2avic    cpu_has_svm_feature(SVM_FEATURE_X2AVIC)

... and this is mostly ordered by feature number. Maybe add an pre-req patch to sort them, and then re-do patch 2 and this patch to insert in feature order?

Re-ordered (for both patches):

Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>

Thanks,
Jason



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.