[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 14/28] x86/hvm: vlapic: update signatures of both vlapic_{clear,test}_*
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: dmukhin@xxxxxxxx
- Date: Thu, 5 Nov 2026 12:11:59 -0800
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 205.220.161.53) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=ford.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com; dkim=pass (signature was verified) header.d=ford.com; arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k9+nX7rqR0aWeqB5DqB9W5f9dYZbObbrwXglaBheaE4=; b=FdfRxCYXdXH62cpV+rK15QRrLUZs27mHgLYS6mVXYg1oy2eyFQ08s4BOWK6TXZC6DkeGK6OvCywBkQR+blHHd0SzXg9hURIE3y9UnXgzEZJtCCjNxM5SOeQr4cp+Nlf98BmXWTR0fT0gERcJ7lpwqadMva/kq0dd+u9XJ0exi36b+nPK/GR0QOKw9TVNYbhpCP7UUBOYDYuj7dsox1D0BMbmmhvqzNe2XWNU/Rh2IVqge1sxx7wDRRFqfct3wG3USP+4rjV3ciVByvqQ3ZIpoYpfCLjJsXOEEWZQYRvYd+Sos0it4P+BGCI4YvWZ9/1/4qmQLtG9pvDn3Z3p6Q2FNQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=n9/mlfa2T1K0uf2x/SYkkC5MUCDfHZczltmmKr52wjYwUxuKYuq+BhLmBdU3J8fpRqZA56+tDYf1WBrn+mQPF4G1pRn26ptv+vr/e4G2b5w719nFLqGEi6rPF/OCpUmzstpxlaguUqj/uJTHBhFeZwfUbtLC10rC+u3AFywbteb98ynr0eX7dDcyX0gHgLPAzu5rbImyx6tDAGOtje4mjKs1F7SjbnVYzzt70GzqiRlffRfK8wjB5Umb6fmGOl5f5O1VAwDgymk7i+g3is3MSEzSwZDD+mOQqqwmRnIJUicyl8fnFG1xuM2kldz5RavI6ey9thhlFdKd5gNxek3GKg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=ppford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector2-azureford-onmicrosoft-com header.d=azureford.onmicrosoft.com header.i="@azureford.onmicrosoft.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=ppserprodsaar header.d=saarlouis.ford.com header.i="@saarlouis.ford.com" header.h="Cc:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=ppfserpocford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"
- Cc: dmukhin@xxxxxxxx, andrew.cooper3@xxxxxxxxxx, jason.andryuk@xxxxxxx, roger@xxxxxxxxxxxxxx, teddy.astie@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 05 Nov 2026 20:12:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Pser-m365-app: SER-APP
On Thu, Nov 05, 2026 at 09:33:17AM +0100, Jan Beulich wrote:
> On 05.11.2026 02:33, dmukhin@xxxxxxxx wrote:
> > --- a/xen/arch/x86/hvm/vlapic.c
> > +++ b/xen/arch/x86/hvm/vlapic.c
> > @@ -85,14 +85,14 @@ static int vlapic_find_highest_vector(const void
> > *bitmap)
> > * IRR-specific bitmap update & search routines.
> > */
> >
> > -static int vlapic_test_and_set_irr(int vector, struct vlapic *vlapic)
> > +static int vlapic_test_and_set_irr(struct vlapic *vlapic, uint8_t vec)
> > {
> > - return vlapic_test_and_set_vector(vector,
> > &vlapic->regs->data[APIC_IRR]);
> > + return vlapic_test_and_set_vector(vec, &vlapic->regs->data[APIC_IRR]);
> > }
> >
> > -static void vlapic_clear_irr(int vector, struct vlapic *vlapic)
> > +static void vlapic_clear_irr(struct vlapic *vlapic, uint8_t vec)
> > {
> > - vlapic_clear_vector(vector, &vlapic->regs->data[APIC_IRR]);
> > + vlapic_clear_vector(vec, &vlapic->regs->data[APIC_IRR]);
> > }
> >
> > static int vlapic_find_highest_irr(struct vlapic *vlapic)
>
> Each of the functions only having ...
>
> > @@ -166,7 +166,7 @@ void vlapic_set_irq(struct vlapic *vlapic, uint8_t vec,
> > uint8_t trig)
> >
> > if ( hvm_funcs.deliver_posted_intr )
> > alternative_vcall(hvm_funcs.deliver_posted_intr, target, vec);
> > - else if ( !vlapic_test_and_set_irr(vec, vlapic) )
> > + else if ( !vlapic_test_and_set_irr(vlapic, vec) )
> > vcpu_kick(target);
> > }
> >
> > @@ -1414,7 +1414,7 @@ int vlapic_ack_pending_irq(struct vcpu *v, int
> > vector, bool force_ack)
> > !viridian_synic_is_auto_eoi_sint(v, vector) )
> > vlapic_set_vector(vector, &vlapic->regs->data[APIC_ISR]);
> >
> > - vlapic_clear_irr(vector, vlapic);
> > + vlapic_clear_irr(vlapic, vector);
> >
> > return 1;
> > }
>
> ... a single caller: Do we actually need those helpers?
Yeah, I would rather drop these...
Thanks for suggestion!
>
> Jan
>
|
