[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/4] xen/arm: acpi: resolve MISRA C Rule 11.8 in acpi_xsdt_modify_entry()
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
- Date: Tue, 3 Nov 2026 10:29:18 +0000
- Accept-language: en-US, uk-UA, ru-RU
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vmiPFQmUYyT/jB4MHBpHaH92O7sxAxWv+3/3HBRBYL0=; b=SgdR14f72OX7oOoIQ+9dcfmGKfhz4pKbwXhQb63iliNLNRNgwoIsmAFzXAEh85CM0FOv56xqtJAfL50Ps++s/bQv2CjY0Qnl4JkKeNLZtV2FHIM5Ip4rBwtt56ULmw/zgLPze8D9FP0PIOSz61bSaPyY9XZhPfAx5ZOJoiw3JBkUrq+o8rEPpTwcEtDB4wIrZ1KN2ZntGKqCDWTuYZ38OigmEBDPmpM2rsIWRRrtU6OjJgZwNyIJ2PlsCLlG0wuFD9npphkXqeVxBp5HNnNM7nsNzezHMkU+DTHNjzPkprImIDPaQg5DV4iAgs5iaBzWShaC5ushfYGiYmEZKntaGg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=y7kJizY+OehPe2BMuQ9QdTww+BEzUZyu7+jzAopMnhd/YoSnBV4nB8Zb5PfapptH+vM3Ub2ToQI956QEQ4ADIj+FfdAfYXMxqdWPO4lohLm6Y/iXja6Nj6D9NSvcRMsQbtA+JogroJGnmUjyehZ/KV+nZ9AkRm2PHWJxAuiYz1kJ9S6kL/2CjgC9yQN/byj//lFU3BQLlBdYw32tRgPMhK0Vt1FhpDHd07RKsfKc+ZfY6Yq4lmVvEqVTXPmrpL2AzHmzmu32QCulw+gvrpl+vbaWMjOHacFdD56b/mQXJvWi/4v3wxHYEFBXnIJ3RrNo6e3XuxKl6+53mxTvRRtYEw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 03 Nov 2026 10:29:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHda34uogvF1bUNYUC6rEVk8qUrxQ==
- Thread-topic: [PATCH 2/4] xen/arm: acpi: resolve MISRA C Rule 11.8 in acpi_xsdt_modify_entry()
ACPI_COMPARE_NAME() casts both of its arguments to 'u32 *' through
ACPI_CAST_PTR(). The 'signature' argument of acpi_xsdt_modify_entry()
is 'const char *', so the macro casts away its const-ness, which is
a violation of MISRA C Rule 11.8.
Use strncmp() with ACPI_NAME_SIZE instead. It takes 'const char *'
arguments, so no cast is needed at all. It also avoids reading a 'u32'
through a possibly unaligned char pointer.
No functional changes.
Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
---
xen/arch/arm/acpi/domain_build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/acpi/domain_build.c b/xen/arch/arm/acpi/domain_build.c
index db16f7fa94..a77a51afd5 100644
--- a/xen/arch/arm/acpi/domain_build.c
+++ b/xen/arch/arm/acpi/domain_build.c
@@ -253,7 +253,7 @@ static void __init acpi_xsdt_modify_entry(u64 entry[],
for( i = 0; i < entry_count; i++ )
{
table = acpi_os_map_memory(entry[i], size);
- if ( ACPI_COMPARE_NAME(table->signature, signature) )
+ if ( !strncmp(table->signature, signature, ACPI_NAME_SIZE) )
{
entry[i] = addr;
acpi_os_unmap_memory(table, size);
--
2.43.0
|
