[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/4] xen/arm: its: initialize host LPI state before activating ITSes
- To: Mykola Kvach <mykola_kvach@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Fri, 23 Oct 2026 12:50:41 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=epam.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G7De5DrU5rp2otcZmYE96HsjyySabRs7G0qpdpG+urc=; b=CyOw1xHE0KGkHB3Ki4HdcWZOqhBTPa9hO2iZlLcz1X/Xej+m7YUDOmN9ivQqG5BFp+bkjvNJQDOq4fE0pDdSy16JRPDt510frFf7wprz10h+jZ/wVin2inleG+Cr/l325NxvE1DoMLhxNm1bYTxNyFSFgy2GH9oLWeAKRxUkH/ZdWM3da7TlERKQ/l6Fk2zq3zTzwAKSLw4kjofdo8Qie996Rt8G362RKS6obg03fvREPRq/xAn6jufDsLqZIe7B0B8ksbk13uQwWfeQYh61bY17/T/5ERuZgWhR+AV1dQS+gNdlZXWzjpZUAI2z+RX/NQ8ysTasJvfxqaIq7Y552g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PscDW/IjrTHDc0Cp8Cd0HXiWAvYeVVS8u8o8K3gqyl0uh7BKR8C8xOjodkXLvkqD3EhjJFtBINiDtyvzbiLvdUMhcyHraVTz8VVBfhWKb3aobVuv+ZQpt5SMLttZBm6A0VgQ1ukREByr+gAhyplZuSrUuUNKCuLhGwuLsrALniN+6orqlFR1qkGd5XzJW56qX7j+XMb2X8E3kZ4lyRR/CNCt1NWGkHNs6qJGWsvWF+TTVjUBO8QO7h1Q/zcsrBYWiOGDnBqb/AsCoPebhUx/ekIlqBkh2M5UFzs0iMiEG9JvSjx8yyBIE4s32MZG1olUTmGovD2TyhFIO6nBZalNMA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 23 Oct 2026 10:51:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29-Sep-26 21:02, Mykola Kvach wrote:
> The boot CPU pending table must use the memory attributes selected by
> ITS quirks. gicv3_lpi_init_host_lpis() is therefore called after
> gicv3_its_init(). However, gicv3_its_init() also programs and enables
> each ITS before host LPI state is allocated. No ITS commands are
> submitted at that point, but this ordering relies on that implementation
> detail.
>
> Split per-ITS initialization into preparation and activation phases.
> First map and disable every ITS and collect its quirks. Then initialize
> host LPI state. Only after that, allocate and program the ITS tables and
> command queue, and enable each ITS.
>
> The subsequent gicv3_cpu_init() sequence remains unchanged: it programs
> the Redistributor LPI tables, enables LPIs, and then submits the first
> MAPC and SYNC commands.
>
> Suggested-by: Julien Grall <julien@xxxxxxx>
> Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
The only caller of gicv3_lpi_init_host_lpis() is now in -its.c file, so we
should drop the stub (can be done on commit). Other than that:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
