[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 24/28] i8259_common.c: remove unused i8259_init_chip() function
- To: pbonzini@xxxxxxxxxx, richard.henderson@xxxxxxxxxx, mst@xxxxxxxxxx, sstabellini@xxxxxxxxxx, anthony@xxxxxxxxxxxxxx, edgar.iglesias@xxxxxxxxx, qemu-devel@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Mark Cave-Ayland <mark.caveayland@xxxxxxxxxxx>
- Date: Mon, 19 Oct 2026 13:04:56 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WyA/oexDigpjp1MqIVZSX3oyJADfec6ddFmZwK/KFs4=; b=e7G52uuha3zPYSwdkkVTR2EWVMbYHI0LffcGz8pWu8kYfIIVc3XNxAZNT5Mk7e0aXXZ4DpUuMS0n7vLdisk0+nd67L5HtBNDlU6wia+t72t5oSqmR6wO5ABOW6+dpYJs7lWSPVLy1tXVmFrkrmRutcqLCxljCwYcAtLybId6n1E7MfKwqqym0fCgGMGpGm6VcdIY7k+PwqH7Tecf4k4TvcJtuq3QPokuGvvXabzW2Punk+swatv4T8a1gdWznOlktKyvKIvYjvNQb9Ygl0HDLCAj7vKY480/GJJ9Y5ABZUbxl7o6TZzn5//vjbeV0O4EO6rgTKj8c+zdAdNwA2sRsQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uMgyNCUcUYf2OVlyKzYGszOKvHn88PYi/fvrR2cgAAih5Dcg2+Gg66IanO60FgjGnBbNK/8sTM1NzM/dg3p6YvmaGIOALN4ZsqeLBZ8zkQmL5n6JmBDUBrGk4kmJmuvCsWALJkswtK+4T3jihZaMTl8Bwt5i9ANkHEZdyIp4uEMihOENTE+xoG/T61rNVX06haitx6rCjSsF6Ivrn5UJVCLhYreuoQ7hEpsWXSExrJ+PP55NL6+kw4syoD62kyeNNWcPdRSrctWSxh+fNphEtPyP3azIqiV18ObdLUSR5ag9QP2tTEgjYXxojObbK0CC+PMyssg+WGnnlUnE0/Qqew==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com;
- Delivery-date: Mon, 19 Oct 2026 12:06:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
This function is now unused and can be removed.
Signed-off-by: Mark Cave-Ayland <mark.caveayland@xxxxxxxxxxx>
Reviewed-by: Peter Maydell <peter.maydell@xxxxxxxxxx>
---
include/hw/isa/i8259_internal.h | 1 -
hw/intc/i8259_common.c | 16 ----------------
2 files changed, 17 deletions(-)
diff --git a/include/hw/isa/i8259_internal.h b/include/hw/isa/i8259_internal.h
index 644508a44e..dd255fac24 100644
--- a/include/hw/isa/i8259_internal.h
+++ b/include/hw/isa/i8259_internal.h
@@ -71,7 +71,6 @@ struct I8259CommonState {
};
void i8259_common_reset(I8259CommonState *cs);
-ISADevice *i8259_init_chip(const char *name, ISABus *bus, bool master);
void i8259_stat_update_irq(int irq, int level);
#endif /* QEMU_I8259_INTERNAL_H */
diff --git a/hw/intc/i8259_common.c b/hw/intc/i8259_common.c
index 09b761321a..5fa38fbc5f 100644
--- a/hw/intc/i8259_common.c
+++ b/hw/intc/i8259_common.c
@@ -89,22 +89,6 @@ static void i8259_common_realize(DeviceState *dev, Error
**errp)
qdev_set_legacy_instance_id(dev, cs->iobase, 1);
}
-ISADevice *i8259_init_chip(const char *name, ISABus *bus, bool master)
-{
- DeviceState *dev;
- ISADevice *isadev;
-
- isadev = isa_new(name);
- dev = DEVICE(isadev);
- qdev_prop_set_uint32(dev, "iobase", master ? 0x20 : 0xa0);
- qdev_prop_set_uint32(dev, "elcr_addr", master ? 0x4d0 : 0x4d1);
- qdev_prop_set_uint8(dev, "elcr_mask", master ? 0xf8 : 0xde);
- qdev_prop_set_bit(dev, "master", master);
- isa_realize_and_unref(isadev, bus, &error_fatal);
-
- return isadev;
-}
-
void i8259_stat_update_irq(int irq, int level)
{
if (level != irq_level[irq]) {
--
2.43.0
|
