[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v3 05/28] i8259.c: rename PICClass to I8259Class


  • To: pbonzini@xxxxxxxxxx, richard.henderson@xxxxxxxxxx, mst@xxxxxxxxxx, sstabellini@xxxxxxxxxx, anthony@xxxxxxxxxxxxxx, edgar.iglesias@xxxxxxxxx, qemu-devel@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Mark Cave-Ayland <mark.caveayland@xxxxxxxxxxx>
  • Date: Mon, 19 Oct 2026 13:04:37 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3vBEVX+niLMJnfCDKjUwa0/HIy/VOW1L2EsbM7q6m2s=; b=QMwtU77merZgRFrNKCoSD6eaDOaCXePXctO49jbZF6XTEDpsMAFU1a7ZoKemMwbISmHra0Z5e/lFlDyXHzRxrBFwTKIMRWFd7kp3gpykTxdl9p6G9aQiJauLMPVMIhFDFajcM5t0MhA9rUeB4GRvSa3cp48ksrR2lyFv2TFLbPDlfHJJVyvV9Z0WS8uWRCyZs7fTonVQa4zdw9HArQwv4THhySO1S1yl81bL3jCQh9l1GMZdatO8jWIeKh7JcQj93Cdr3AxVxM92gZk4/vXP3u9eDZH9lV7Wk2J/FuMt4dUY8V+8YZcGc927i4XXihKudqN3hUUSHzwzm2MuR7BSTw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=agf01a7jUf3qB0weOi972WrpYCuQig4HBqQWNp1AT6VUvuGakDzqk2WXyhk7VOFbhVy+oicgKwh6NUyJh4YIbJCLEkMJ4cvhd++mZd+x8p+4tr5w6NGTjhnkwRqHudKR5e/bDJnvt6FHfQCkRjWuvSASnK0iTXxvGlmilsbTjFuBU5Sj1nv3n6WYZAjJxyCGS1LAjhr9GYQv1w9JppInB0W3oVKtGlzBB9Yn7rsDU3G+UlMif5UPuQzCbvcBkN9k0RCx3foaYIIIP2FbCH6VnIZIBSg7MksmJrHxRkjOUS+i+DAvAZhcrwC28lWuqx4+6SBx3j1VZyDfBE/t9qaPiQ==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com;
  • Delivery-date: Mon, 19 Oct 2026 12:05:46 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

This is in preparation for its use within a QOM type presenting a single
emulated 8259 PIC.

Signed-off-by: Mark Cave-Ayland <mark.caveayland@xxxxxxxxxxx>
Reviewed-by: Peter Maydell <peter.maydell@xxxxxxxxxx>
---
 hw/intc/i8259.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c
index 547e86c5f4..856075a754 100644
--- a/hw/intc/i8259.c
+++ b/hw/intc/i8259.c
@@ -35,15 +35,15 @@
 /*#define DEBUG_IRQ_LATENCY*/
 
 #define TYPE_I8259 "isa-i8259"
-typedef struct PICClass PICClass;
-DECLARE_CLASS_CHECKERS(PICClass, PIC,
+typedef struct I8259Class I8259Class;
+DECLARE_CLASS_CHECKERS(I8259Class, I8259,
                        TYPE_I8259)
 
 /**
- * PICClass:
+ * I8259Class:
  * @parent_realize: The parent's realizefn.
  */
-struct PICClass {
+struct I8259Class {
     I8259CommonClass parent_class;
 
     DeviceRealize parent_realize;
@@ -388,7 +388,7 @@ static const MemoryRegionOps pic_elcr_ioport_ops = {
 static void pic_realize(DeviceState *dev, Error **errp)
 {
     I8259CommonState *s = I8259_COMMON(dev);
-    PICClass *pc = PIC_GET_CLASS(dev);
+    I8259Class *k = I8259_GET_CLASS(dev);
 
     memory_region_init_io(&s->base_io, OBJECT(s), &pic_base_ioport_ops, s,
                           "pic", 2);
@@ -398,7 +398,7 @@ static void pic_realize(DeviceState *dev, Error **errp)
     qdev_init_gpio_out(dev, s->int_out, ARRAY_SIZE(s->int_out));
     qdev_init_gpio_in(dev, pic_set_irq, 8);
 
-    pc->parent_realize(dev, errp);
+    k->parent_realize(dev, errp);
 }
 
 qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq_in)
@@ -435,7 +435,7 @@ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq_in)
 
 static void i8259_class_init(ObjectClass *klass, const void *data)
 {
-    PICClass *k = PIC_CLASS(klass);
+    I8259Class *k = I8259_CLASS(klass);
     DeviceClass *dc = DEVICE_CLASS(klass);
 
     device_class_set_parent_realize(dc, pic_realize, &k->parent_realize);
@@ -447,7 +447,7 @@ static const TypeInfo i8259_info = {
     .instance_size = sizeof(I8259CommonState),
     .parent     = TYPE_I8259_COMMON,
     .class_init = i8259_class_init,
-    .class_size = sizeof(PICClass),
+    .class_size = sizeof(I8259Class),
 };
 
 static void pic_register_types(void)
-- 
2.43.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.