[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] tools/libxenstat: fix output initialisation in parseNetDevLine()



On 16/10/2026 13:55, Baptiste Le Duc wrote:
> The subject says "fix", but the body says no functional change. Either
> it's a bug fix and wants a Fixes: tag, or it isn't, and then I'd use
> Amends: 1fd93d4f8cb8 ("xenstat: Linux dom0 statistics for case we use
> network bonding") and drop "fix" from the subject. Based on the changes, I 
> think the latter.

Agreed, it isn't a bug fix: the only caller passes NULL for rxMcast,
and the other two changes don't alter behaviour. All three come from
1fd93d4f8cb8, so Amends: fits.

In v2 the subject will be "tools/libxenstat: clean up output
initialisation in parseNetDevLine()", with the tag added. I'll wait a
bit for other comments before sending it.

Thanks for the review,
Olivier


--
Olivier Lambert | Vates CEO

XCP-ng & Xen Orchestra - Vates solutions
Book a meeting with me: https://calrs.vates.tech/u/olivier-lambert
web: https://vates.tech

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.