Re: [PATCH 10/15] x86/PVH: convert find_memory() to using a rangeset

[Roger Pau Monné <roger@xxxxxxxxxxxxxx>]

On Mon, Oct 12, 2026 at 10:24:44AM +0200, Jan Beulich wrote:
> Subsequently we will need to exclude a 2nd range here. To avoid
> complicating the logic when it needs to cover two ranges, follow the
> suggestion left in a code comment and convert to using a rangeset.
> 
> Suggested-by: Xenia Ragiadakou <xenia.ragiadakou@xxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Roger Pau Monné <roger@xxxxxxxxxxxxxx>

> ---
> The Suggested-by: is based on the respective commit's S-o-b. I didn't go
> hunt for whether this may have been suggested in review of that patch.
> 
> --- a/xen/arch/x86/hvm/dom0_build.c
> +++ b/xen/arch/x86/hvm/dom0_build.c
> @@ -518,14 +518,38 @@ static int __init pvh_populate_p2m(
>  #undef MB1_PAGES
>  }
>  
> +struct mem_info {
> +    size_t size;
> +    paddr_t addr;
> +};
> +
> +static int cf_check __init _find_memory(

I don't really like underscore prefixed functions, I would rather name
this check_memory_range() or similar.

Thanks, Roger.