[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/11] Compiler Attributes: Add __require_explicit_initialization macro
- To: Ian Rogers <irogers@xxxxxxxxxx>
- From: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx>
- Date: Wed, 14 Oct 2026 13:28:55 +0200
- Arc-authentication-results: i=1; mx.google.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=xWJCwZOmpC49YtbA7QzlowrBvokYI4WD90uvALsrwIA=; fh=yPtcoeQFsAo9lXGb61vAWgz6GoL9BIq2U4FsndOWfJY=; b=WAR8VeJOC6B67SX7XZ1e+VsRytDCC5h+u3ujDRdoVL0TglG2vOpGTRDSEunJV8Em17 31v0o42w1SCaj5o1OfPOJ+XGSqjOhPhXqxeu6JL4p3coawVjqlIdxc9m3c/Bz9gUsBXm 6xvNJdKy4SuXtlM0o8c412qwCtyo5uWKW/1iWau2zwJm7yq7xdO2r/9BhaDJELrAa6mY B2x5MdVrVIpcdHaNT4nYhJsXAmRhstknGkGZcH4ATd9fC/4Yh4yoetgTsmxjrbTWK2uy cwj2YgTa6+s69QZKupOk51xhZFjG8f4JYLyqbHFHtll7EnYX3jv/Dfll0vrejA9JhDxK Cyqg==; darn=lists.xenproject.org
- Arc-seal: i=1; a=rsa-sha256; t=1791977348; cv=none; d=google.com; s=arc-20260327; b=Uj5rfTIRTdHTmQmz5l2RGtvJXZBoiv0SLPAAG8cN8boW67AJFfKXfe6hgXzgR1FeVR pB0ir/fI3O6doonB3Nxi8Q2WGHe6nff2XscRpsW/+Ul4Hw+5uOxDdOa1QQ+1AtDMGW/t YNpNP9Ys5c0qK8EA4mZz1rKX5emzoiK4Yn2RIPyBt5GaTBUXy474Cfh2RNEHVxRu5jmI M8Li5g0Gvb5wgMbMbPZn9n9DzxsJWtpIRMRuL2wYhT38uS2pLODBgkIdqXrOohqQYlM2 4rNHahWseb2IzTBfrYfd+l3dhIzA0XGXgjVIFsNxw5XjOh76BgbkVMesKQDGaqrdrmuw 5Rjw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version"
- Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, "Rafael J . Wysocki" <rafael@xxxxxxxxxx>, Danilo Krummrich <dakr@xxxxxxxxxx>, Miguel Ojeda <ojeda@xxxxxxxxxx>, Kees Cook <kees@xxxxxxxxxx>, Nathan Chancellor <nathan@xxxxxxxxxx>, Nick Desaulniers <ndesaulniers@xxxxxxxxxx>, Bill Wendling <morbo@xxxxxxxxxx>, Justin Stitt <justinstitt@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Madhavan Srinivasan <maddy@xxxxxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, Christophe Leroy <chleroy@xxxxxxxxxx>, Nayna Jain <nayna@xxxxxxxxxxxxx>, Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>, Rich Felker <dalias@xxxxxxxx>, John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>, Viresh Kumar <viresh.kumar@xxxxxxxxxx>, David Teigland <teigland@xxxxxxxxxx>, Alexander Aring <aahringo@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Heiko Carstens <hca@xxxxxxxxxxxxx>, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Alexander Gordeev <agordeev@xxxxxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>, Sven Schnelle <svens@xxxxxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Zhihao Cheng <chengzhihao1@xxxxxxxxxx>, Felix Kuehling <Felix.Kuehling@xxxxxxx>, Alex Deucher <alexander.deucher@xxxxxxx>, Christian König <christian.koenig@xxxxxxx>, driver-core@xxxxxxxxxxxxxxx, llvm@xxxxxxxxxxxxxxx, linux-hardening@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, linux-pm@xxxxxxxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx, gfs2@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, amd-gfx@xxxxxxxxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- Delivery-date: Wed, 14 Oct 2026 11:29:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Oct 14, 2026 at 12:40 AM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> +/*
> + * Optional: not supported by gcc
> + *
> + * clang:
> https://clang.llvm.org/docs/AttributeReference.html#require-explicit-initialization
> + */
> +#if __has_attribute(__require_explicit_initialization__)
> +# define __require_explicit_initialization
> __attribute__((__require_explicit_initialization__))
> +#else
> +# define __require_explicit_initialization
> +#endif
The LPC slides mention Clang 14+, but from a quick test in Compiler
Explorer and a `git log --grep` on the LLVM repository to confirm, it
seems the attribute was introduced in Clang 20+, no?
If that is correct, then it is not available in all LLVM versions we
support (LLVM 17+), so we should add:
* Optional: only supported since clang >= 20.0
With that:
Acked-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
Thanks!
Cheers,
Miguel
|