[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 20/22] i8259.c: switch isa_pic from I8259CommonState to I8259PICState
- To: Mark Cave-Ayland <mark.caveayland@xxxxxxxxxxx>
- From: Peter Maydell <peter.maydell@xxxxxxxxxx>
- Date: Tue, 13 Oct 2026 17:26:41 +0100
- Arc-authentication-results: i=1; mx.google.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=lfW0nUOSaRUIuZAH3PPaoOxVv0uganAcfQGMmdwJiqI=; fh=9VMul4XEbI4AZThU/pUXmxEzBjQG999I7MjlUiUptPs=; b=GMEDKwkl8zMfWRj5DpDxXSFdsFg4T83BRkcMiyDyE1xDvgW5qbl/AmmVzucq1FfFWA KWz3yyFeI0Dm2N19xiOLbxRLzcLXml/5M9G1sLavBvekxXsxH5Mc6HpMm3klwcKWPGDx tJD/ffATRDRJYACBqBQdjSPylPmgpg2BCDEaLQThH8Y+IYAr4szX7lXB+LgazrXoKZYr fF/UkOi/qV1CdefUpLSVCL+AJZ9N14u1zTQUCheJlfpxerMvv1GJfVNQWzFfTuvmiyX1 XXgOhT1RWgLvcGV5WQmTaUx1mt64Pez6SBDgM3RXUUJRDnLZvVKLSsdRtUaOs/PFtpKu HsPQ==; darn=lists.xenproject.org
- Arc-seal: i=1; a=rsa-sha256; t=1791908812; cv=none; d=google.com; s=arc-20260327; b=ATbktG6+tw+meNWDiT1JJIaiBsg1SnUCURcbYeKkpYNbzckOmfFJMPF2HhnfwG1gpW wxhZxHhCbZX3TYceshSqa4o8KG1N2ErURmfIOBgkW+hNyIzlrTzeK+laocwKgU6v84PJ ik2tIoo7etis8wsIeQvBqNSHIYAE/YhRARcp5ZZdB+ElGBqlc7PO0Km3fs4U/nCzgWvJ 1WcXeyA+XXycLxMEmGVpRNNASshIxB8DzpO1TDhR8iVYCISjmsV0juH+ZrBLhkRAREUn 5lprpetpWVunPEm/l9DeWkLtFcqXKLkN9hbefgFo2iiO0Av8S0fq/wnJbLFG6bcKqNM1 9/Dg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=linaro.org header.i="@linaro.org" header.h="Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version"
- Cc: pbonzini@xxxxxxxxxx, richard.henderson@xxxxxxxxxx, mst@xxxxxxxxxx, sstabellini@xxxxxxxxxx, anthony@xxxxxxxxxxxxxx, edgar.iglesias@xxxxxxxxx, qemu-devel@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 13 Oct 2026 16:26:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, 16 Sept 2026 at 11:49, Mark Cave-Ayland
<mark.caveayland@xxxxxxxxxxx> wrote:
>
> The isa_pic variable exists to allow the output to be fetched or read (fetched
> and acknowledged) from the x86 PIC. Since this can also contain a cascaded
> interrupt from a slave i8259, switch isa_pic from I8259CommonState to
> I8259PICState and update both pic_get_output() and pic_read_irq() accordingly.
>
> This has the advantage that a i8259-based PIC device contains its own internal
> reference to both the primary and secondary i8259s, and therefore it becomes
> possible to completely remove the slave_pic variable.
>
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@xxxxxxxxxxx>
> ---
Reviewed-by: Peter Maydell <peter.maydell@xxxxxxxxxx>
(That isa_pic global is kind of ugly; in an ideal world the callers
would have a pointer to the PIC they cared about rather than relying
on there being exactly one in the system...)
thanks
-- PMM
|
