[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 14/22] i8259.c: properly cascade secondary i8259 from primary i8259
- To: Mark Cave-Ayland <mark.caveayland@xxxxxxxxxxx>
- From: Peter Maydell <peter.maydell@xxxxxxxxxx>
- Date: Tue, 13 Oct 2026 17:18:38 +0100
- Arc-authentication-results: i=1; mx.google.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=uSFyrq7MF/+dr64UynPLy/FZzbgropuXsz8I5b5n0xU=; fh=VwtwRxvmUGcZ/TBb85CG3vKSYMtkrE5D9a3D4QmDid8=; b=d1thSJROmq01LiwHHHbt3zryrNL8E8nie+QQ9pDzU0uegdVY3msQfVL0Dx6DXiMI9k f9t16+B2Zr1DMGb0CKu3TVlD2BTsACkvNDuYcgXPEcbebr/bVEPXbQQjmDHn3TtZbN6i xELd0ZQnReZZN4M6KmtjqvArU0qRBD8lgAHzaKmcOlb5/eF5zriPTYBt5Iiz7aRkl46a /KHgUMQyrHFXcOd5aOG4mbYuG4OIhlsDRD3r6jF0ji3rdqOgW3OgzCNdAaSKmKugMkRU qvv0Is6CxkWo4p8yte/QTL1w8LUd8J/RB9X08OLaT2jkoy2sDPuCOhLg8sWJ56wAWTfr LjWQ==; darn=lists.xenproject.org
- Arc-seal: i=1; a=rsa-sha256; t=1791908331; cv=none; d=google.com; s=arc-20260327; b=fe9kZjPuCY0UfDjK/wNzCko0DXjyV27uG6t0b3Xmqm4gT5NYIu4wo85C/M4oSkJpq0 K7SM2A3KGHk4/Itj2XTj+POwwtexrNs8D/KGFTgrvSjNvfV82BKYvN4ivSg9+7Ld3Iiq b7e/dnmtiBzV40MmlLbT1/YjQKk0Xthh//9VwKYnMcx4uBO/yPFC7Krb0drAbzFy89/g g+fBbO6NA7hHXBTKj8CuTJzdrYyMnQmxq/FpJ+aDhthY0TeIC8sQzqoqMVfupz5tbtJ3 95qdO/yneZS6Qhz3EZ63GDdOvkvXudO/ZGVp47DOT8hl8G/rwnY8h7aRmn+QIdIVgQIL nVsw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=linaro.org header.i="@linaro.org" header.h="Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version"
- Cc: pbonzini@xxxxxxxxxx, richard.henderson@xxxxxxxxxx, mst@xxxxxxxxxx, sstabellini@xxxxxxxxxx, anthony@xxxxxxxxxxxxxx, edgar.iglesias@xxxxxxxxx, qemu-devel@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 13 Oct 2026 16:18:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, 16 Sept 2026 at 11:49, Mark Cave-Ayland
<mark.caveayland@xxxxxxxxxxx> wrote:
>
> Currently the cascaded output from the secondary i8259 is returned directly in
> the pass_irqs[] array, instead of being connected to the relevant input of the
> primary i8259.
>
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@xxxxxxxxxxx>
> ---
> hw/intc/i8259.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c
> index fcc94e12f8..964ceb04b2 100644
> --- a/hw/intc/i8259.c
> +++ b/hw/intc/i8259.c
> @@ -501,7 +501,8 @@ static void i8259_pic_realize(DeviceState *dev, Error
> **errp)
> }
>
> /* Wire up secondary cascade */
> - qdev_connect_gpio_out(sec_dev, 0, s->pass_irqs[2]);
> + qdev_connect_gpio_out(sec_dev, 0,
> + qdev_get_gpio_in(pri_dev, 2));
We just added this line in the previous patch, so we might as well
squash this change into the previous one I think.
-- PMM
|
