[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/22] i8259.c: use i8259 prefix for functions
- To: Mark Cave-Ayland <mark.caveayland@xxxxxxxxxxx>
- From: Peter Maydell <peter.maydell@xxxxxxxxxx>
- Date: Tue, 13 Oct 2026 16:58:33 +0100
- Arc-authentication-results: i=1; mx.google.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=DZuhEJteCjiBcxYMsQ5/Kb0n1Eh3plqb2K4/0ypuhTg=; fh=CAgUrIXa0DSX39LmKILE0T8Wu6Oin3YfOZR8uLe6iJQ=; b=qJipOsmNn9sjvVh+KcF6OSrkmf5tcIm8aZ572lg/zoOg724kXbFbV/SWZOqLIQvjWT pSdadYPggwABGwpUyf+/5O3M/DWfWZPmc75YAc/Et5TLAFQj++NT6W71cKwSbuRvnJU2 DlF5GbpI06dsHUc07fH3G3O6fm9v0yuKY6nX2z2W0HlxS1PyIUSEn6lVlLhcH9dKa+ml cx4ewFrP96hDkwrcyYn97vkAax4gOmQDuW13WZD0ayu12wVIuWIycvPLixdQgPmtMkGB nsQj99hDbTAQSuiPm1bfOCoZ9d0BgHH9EZKLDI16lRO2THnsDG3AvN11G7h+oSYjJIB/ QK4A==; darn=lists.xenproject.org
- Arc-seal: i=1; a=rsa-sha256; t=1791907125; cv=none; d=google.com; s=arc-20260327; b=AZFl+RK2gBK39j6p4BFB/NcJCrGhe5qpEKKkeGTP3HhrThS+WIMkSrs6n9ucwImm0B GBoXGx9ZFAhxppHHUqZFB7M2u+QYBTcGoCWnyrHqBS3P1gMmNFHvPfyO/cW2kVULXpMu u//4Ov3iP9XHpTIC89U8lGdzV6oXJKGbdq23M5YiC7y367DKQ9wlmaeuESOtQt3njeVe r1XAfBaIUhdmZnFLB2WBLfk7vKTMls23U4dGyq39d4Ijhh6pVIUIsVVeNDbKauF+0nlZ ES1GNYh3+uBdV57GgfsrzP8TWH4s1q0attfoh+CUUe4NjdlexD1r+lgTGO9m1WQa7ZQQ Lbbw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=linaro.org header.i="@linaro.org" header.h="Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version"
- Cc: pbonzini@xxxxxxxxxx, richard.henderson@xxxxxxxxxx, mst@xxxxxxxxxx, sstabellini@xxxxxxxxxx, anthony@xxxxxxxxxxxxxx, edgar.iglesias@xxxxxxxxx, qemu-devel@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 13 Oct 2026 15:58:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, 16 Sept 2026 at 11:49, Mark Cave-Ayland
<mark.caveayland@xxxxxxxxxxx> wrote:
>
> This ensures consistency with our normal QOM-based naming convention.
>
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@xxxxxxxxxxx>
> FIXME: rename trace events?
I recommend removing FIXME comments before posting patches, it avoids
the possibility of reviewers suggesting you do the extra work :-)
I don't believe we make any claims about stability of trace event
names, so we could rename them. Should be a separate patch if we do,
though.
For this patch and with the FIXME line removed,
Reviewed-by: Peter Maydell <peter.maydell@xxxxxxxxxx>
thanks
-- PMM
|
