Re: [PATCH v7 0/5] Fix ARM domcreate

["Orzel, Michal" <michal.orzel@xxxxxxx>]

On 12-Oct-26 15:36, Julian Vetter wrote:
> Hello Michal and Anthony,
> thank you for the reviews and acks! Michal, I have addressed your
> remaining remarks on the "xen/arm: report clock_frequency via sysctl
> physinfo, not createdomain" patch. The golang bindings are regenerated
> for the new arm_clock_frequency_hz physinfo field, and
> alloc_domaininfo() no longer references the removed clock_frequency
> field. Apart from that I have collected the Acked-by/Reviewed-by tags.
> 
> Signed-off-by: Julian Vetter <julian.vetter@xxxxxxxxxx>
I was about to commit the series but I found out that some tests like
test-mem-claim and possibly others still pass gic_version=0 which will cause the
domain creation to fail. You need to update the tests.

> 
> Andrew Cooper (1):
>   ARM/sysctl: Expose the supported guest GIC modes in physinfo
> 
> Julian Vetter (4):
>   tools/arm: choose GIC version explicitly instead of relying on
>     GIC_NATIVE
>   xen/arm: remove XEN_DOMCTL_CONFIG_GIC_NATIVE from the ABI
>   xen/arm: report clock_frequency via sysctl physinfo, not createdomain
>   xen: make config argument const
Here you are still missing tags from e.g. RISCV I think.

~Michal

> 
>  CHANGELOG.md                                  |  4 ++
>  docs/man/xl.cfg.5.pod.in                      |  4 +-
>  tools/golang/xenlight/helpers.gen.go          |  2 +
>  tools/golang/xenlight/types.gen.go            |  1 +
>  .../include/xen-tools/arm-arch-capabilities.h | 31 ++++++++
>  tools/libs/light/libxl.c                      |  1 +
>  tools/libs/light/libxl_arm.c                  | 72 +++++++++++++++++--
>  tools/libs/light/libxl_types.idl              |  1 +
>  tools/ocaml/libs/xc/xenctrl.ml                |  1 -
>  tools/ocaml/libs/xc/xenctrl.mli               |  1 -
>  tools/ocaml/libs/xc/xenctrl_stubs.c           |  5 +-
>  tools/python/xen/lowlevel/xc/xc.c             | 18 ++++-
>  xen/arch/arm/dom0less-build.c                 |  3 +-
>  xen/arch/arm/domain.c                         | 32 ++++-----
>  xen/arch/arm/domain_build.c                   |  3 +-
>  xen/arch/arm/firmware/sci.c                   |  2 +-
>  xen/arch/arm/firmware/scmi-smc.c              |  2 +-
>  xen/arch/arm/gic.c                            | 15 ++++
>  xen/arch/arm/include/asm/firmware/sci.h       |  6 +-
>  xen/arch/arm/include/asm/gic.h                |  6 ++
>  xen/arch/arm/include/asm/time.h               |  7 +-
>  xen/arch/arm/include/asm/vgic.h               |  6 ++
>  xen/arch/arm/include/asm/vtimer.h             |  3 +-
>  xen/arch/arm/sysctl.c                         | 34 +++++++++
>  xen/arch/arm/time.c                           |  9 ++-
>  xen/arch/arm/vgic-v2.c                        |  5 ++
>  xen/arch/arm/vgic/vgic-v2.c                   |  5 ++
>  xen/arch/arm/vtimer.c                         |  4 +-
>  xen/arch/ppc/stubs.c                          |  2 +-
>  xen/arch/riscv/domain.c                       |  2 +-
>  xen/arch/x86/domain.c                         | 16 ++---
>  xen/include/public/arch-arm.h                 | 18 +----
>  xen/include/public/domctl.h                   |  4 +-
>  xen/include/public/sysctl.h                   | 22 +++++-
>  xen/include/xen/sched.h                       |  5 +-
>  35 files changed, 269 insertions(+), 83 deletions(-)
>