[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4] common: dom0less-bindings: introduce XSM labels
- To: "Jan Beulich" <jbeulich@xxxxxxxx>
- From: "Alejandro Vallejo" <alejandro.garciavallejo@xxxxxxx>
- Date: Tue, 13 Oct 2026 13:40:42 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x78XjEP0pIg/q5IyayNJO4LmQYDgFMyINQZGULwqKkQ=; b=DI5qbFWGTFbFDptnd4yDsLm08yBAirhswFuwZQaa62WcykkG0/dm9bZ/RQJXVXaCZkYe550mTUnpU4h1vBK62nUGXAI+CnGUWs5XZFANNxz3IuwNp3AWQ1PJvoc70yPEiaBVts27ky6TZOgcZvdX+RAWyrV7L50492EGIbSkL8BOorQfGfF5bqOtdRQkxgZj75Z3pVu14xLHIvPTdjLSVG/X0hHtf6G+90rg0ecG3yXU/WgE6O4LHWbZmCl6qX0+xHHg+n0UVot2OJqUKy52bAxHUi5FcN0dhAMY5Z6/nOeSW6AyPWs1s2NSVsIkhqEhiGkfTtLt8PfNpjQ8Y+5SnQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bTP8xZvPqo2YCGvhQnY8iftheeB76kVbM+NrI8QLYi/eWr+vl96cfZ0LeW0ugRMSJ672N0hhmgduc4t6eFRrLwRhLxuKN1F5UAt0mmxxqJtsHSG/EpDiIPujp7s2r+/auz5mACp3bsMxQPowQHBZbTzqoOCNhBC0a35AnWzyqmJfni0E45JKkbBjzeeAqMKTKgGIBEowllayWaHncpjDfwAmJSPBsjH1F/P3VVTCaDFdOleKpMb2/mC2j2zq1rC8iaqnUaZhgveGpJOMFNrMJnNVrHEbxskfJn9NGCjU+V5ajbdcKztQF11e/4BwEKFQpvt59U7WtNvybSfj0L5bIw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-Id:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, "Julien Grall" <julien@xxxxxxx>, "Bertrand Marquis" <bertrand.marquis@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, "Michal Orzel" <michal.orzel@xxxxxxx>, "Sergiy Kibrik" <Sergiy_Kibrik@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 13 Oct 2026 11:40:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue Oct 13, 2026 at 11:17 AM CEST, Jan Beulich wrote:
> On 13.10.2026 11:09, Alejandro Vallejo wrote:
> > On Mon Oct 12, 2026 at 12:15 PM CEST, Sergiy Kibrik wrote:
> >> --- a/xen/include/xsm/dummy.h
> >> +++ b/xen/include/xsm/dummy.h
> >> @@ -823,4 +823,11 @@ static XSM_INLINE int xsm_domain_resource_map(
> >> return xsm_default_action(action, current->domain, d);
> >> }
> >>
> >> +static XSM_INLINE int xsm_lookup_sid(
> >> + XSM_DEFAULT_ARG const char *ctx, uint32_t len, uint32_t *sid)
> >> +{
> >> + /* dummy policy has no security contexts */
> >> + return -EPERM;
> >
> > nit: Perhaps -ENOSYS? or something like that. It's not that any
> > permission was violated, it's that the real version of this function is
> > absent.
>
> Yet then still e.g. -EOPNOTSUPP, but certainly not -ENOSYS.
That'd also be ok.
It would be helpful if there was a guide under docs/ in which we state
what each of our errnos are meant to be in Xen terms. ENOSYS/EOPNOTSUPP
are great examples of such mixed usage that it's disheartening trying to
reverse engineer the policy from their use.
Cheers,
Alejandro
|
