Re: [PATCH 06/15] x86/PVH: keep a copy of Dom0's initial E820 map

[Jan Beulich <jbeulich@xxxxxxxx>]

On 13.10.2026 08:57, Teddy Astie wrote:
> Le 12/10/2026 à 10:23, Jan Beulich a écrit :
>> @@ -1389,6 +1395,15 @@ int __init dom0_construct_pvh(const stru
>>   
>>       iommu_hwdom_init(d);
>>   
>> +    nr_orig_e820 = d->arch.nr_e820;
>> +    orig_e820 = xvmalloc_array(struct e820entry, nr_orig_e820);
>> +    if ( !orig_e820 )
>> +    {
>> +        printk("No memory for copy of E820 map (%u entries)\n", 
>> nr_orig_e820);
>> +        return -ENOMEM;
>> +    }
>> +    memcpy(orig_e820, d->arch.e820, nr_orig_e820 * sizeof(*orig_e820));
>> +
> 
> I don't know if that matters much, but if anything after 
> (pvh_place_kernel, pvh_place_acpi, ...) fails, we leak orig_e820.

Yes - we're about to panic() anyway.

Jan