[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH net-next v2 00/10] net: stop calling __pskb_pull_tail() from drivers
- To: Jakub Kicinski <kuba@xxxxxxxxxx>
- From: Josef Bacik <josef@xxxxxxxxxxxxxx>
- Date: Fri, 9 Oct 2026 09:43:31 -0400
- Arc-authentication-results: i=1; mx.google.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Cr53QXzLPPnzzAYL9+Ow9RuREkmHHvveZLDzlgyx6as=; fh=f4v+fmtPwzY0SRokZxYCwr5G2OFpMlb0pe8xMOD0FGI=; b=UXnu9gGWD9cs1LJhf1y0axFIHtB/mJYvDG4x+IFKcoSe9pvAzrDFYqP7I0Ukkp5HLo RZmFHQUrX6/+3v3JGRWuoDvBh13J0jpdfrkVSEKn8/7/2UoAEkawtkBeBf1u74USkrSM WGWSAvCi8sSi41wXTMEwUAYPaAifQ8Xm0JUaXke6EE+mJvzChx9PAbChelu9vnA+3ZUn LbpcyIb8wCiyx+D7wgcCkt3qe3CR//lVIQylqxbSTeN7UpKEtDpoAFtRLbZheCVjztPw b84gD/NOJR6pdbiaI9K3iEAMA2zZYAArK6HLBIDUHGLHxIybxqi3HtZkmisUVYVO2jPj ujxA==; darn=lists.xenproject.org
- Arc-seal: i=1; a=rsa-sha256; t=1791553424; cv=none; d=google.com; s=arc-20260327; b=NYFhxVb5diyr7jjBZJbK8Aude9UoV43ZL0UR/Pc8WHI608GtNj+/LpT5RrUtoie8Vi mhxFSQVUKbEKRkFh1e33AyC6Yi3mRhNZJ7Ss+C9lpAAgtn7uRZ6WYTuDQFi2K9Hu126Z GXMmwQKNRcd58f1rxAD/12Lhuc9DYTpig4l2O8W0MPjhbOkBc95EvwDDFpySQmcTd7pM BqRq3A57Hhqy8RIMr26UmvmsNyjn19EDh136TUXc1fvcxm6e0zfdPwdvj970hH7TsE2i lrq7U5EaBA+1w1IyoJrgiMA0MkhjL4x5TOGv/zUWSBal9fJIZBpstnpXVGJ+IInBdZgr 9snA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=toxicpanda.com header.i="@toxicpanda.com" header.h="Content-Transfer-Encoding:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version"
- Cc: Paolo Abeni <pabeni@xxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Andrew Lunn <andrew+netdev@xxxxxxx>, Saeed Mahameed <saeedm@xxxxxxxxxx>, Tariq Toukan <tariqt@xxxxxxxxxx>, Mark Bloch <mbloch@xxxxxxxxxx>, Leon Romanovsky <leon@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Tony Nguyen <anthony.l.nguyen@xxxxxxxxx>, Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx>, Manish Chopra <manishc@xxxxxxxxxxx>, Rahul Verma <rahulv@xxxxxxxxxxx>, GR-Linux-NIC-Dev@xxxxxxxxxxx, Shahed Shaikh <shshaikh@xxxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, intel-wired-lan@xxxxxxxxxxxxxxxx
- Delivery-date: Fri, 09 Oct 2026 13:43:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Oct 8, 2026 at 5:11 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Thu, 08 Oct 2026 21:02:47 +0000 Josef Bacik wrote:
> > v1->v2:
> > - New 1/10: skb_drop_empty_frags(). xen-netfront, netxen and qlcnic
> > relied on __pskb_pull_tail() releasing zero-length frags even when
> > there's nothing to pull, which pskb_may_pull() doesn't do (Sashiko).
> > - xen-netfront, netxen, qlcnic: call skb_drop_empty_frags() after
> > pskb_may_pull().
> > - skb_drop_empty_frags() checked with a boot-time test under KASAN and
> > kmemleak, on cloned and uncloned skbs.
>
> Please keep in mind that we ask people to limit themselves to 15
> outstanding patches per tree. You have 18 right now.
> (200 active netdev contributors + an LLM) x 20 patches == insanity :/
Eesh sorry Jakub, the skbuff BUG_ON() removal series is the more
important one, this series is the followup so I can finish that work.
By outstanding do you mean per-merge window or once I get
notifications for things being merged I'm good to send the next batch?
Thanks,
Josef
|