[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 03/39] xen/riscv: introduce csr_volatile_read64()
- To: Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>
- From: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Date: Fri, 9 Oct 2026 15:29:45 +0200
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID"
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Romain Caritey <Romain.Caritey@xxxxxxxxxxxxx>, Zheng Zhang <zhangzheng@xxxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Fri, 09 Oct 2026 13:30:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/5/26 12:01 PM, Baptiste Le Duc wrote:
On RV32 a 64-bit CSR is accessed as two halves, <csr> and <csr>H. Reading
As far as I can tell RV32 can't currently be selected (RISCV_64 is def_bool y,
no RISCV_32 in Kconfig), so this path can't even be build-tested.
I've tested that manually.
Is the retry
loop really needed now, or a least in this patch series?
I think it is worth keeping the retry loop now so that the code is ready
if RV32 support needs to be added in the future, reducing the changes
required at that point. It also helps explain why a separate
csr_volatile_read64() function is needed in the first place.
~ Oleksii
|
