[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/4] x86/kexec: address Misra rule 11.1 violation in machine_kexec_load()


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
  • Date: Mon, 5 Oct 2026 20:05:31 +0000
  • Accept-language: en-US, uk-UA, ru-RU
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WNfr8oWxnmynHo8sSb62Z4SD4mE4QOwGJ0QSVd6ndr8=; b=gN0zceRL0brh0WmWIe2X0PSY4h2gZaO8kVHTYlM33g/z7Lpxqmd/p0hrtZo6rTKaQFimphcVIdutEsGTlCtmUL9cAAX+51n2EYG+vUMK0BTFfIbrv7Wpb3IxFE3Dhy7z0+uiGSnsLat4qH+OUxLl/XSqw+mBEFLA7UORNm1dSkhVzrql0rPjiNwJIWr2G3FQ17yFOtdxImIUdfHH2n6NgZrYZOc2MP+qtDPwTjFwTRpC1aEkOcHuSA78RtGkAMTXtGQl8Iwfbtp/4/LXkd+SEj77sbOBoCScHSbzl0/DnD7dvUyBoS7gI8MpaD+rhGXSohkYF3BKGhI1MB2bK4DWhA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sTC4PuHp7OjbWfSoigK/8YHbIwUQ6XULiGOiL0U9fAJRhhOSkAJ2UaNz/acajxIiLxRglzoRPwo3Wn/ZS3QjwPIGbR9M/1QoS07N5ePQK7ZgWteBoLtLoNyLXISt8t8neIuASRdWqC/CJnhpopZ801TPt9/Okibn1t3uJCtTgsi60hhpZ1EHbHXkufPeA5FW5siqiupl/7sKvjPzrLrdtbtaLH6UyqrWWMcJ0SLfrYTCW4hNs/9MDEB83iA0kvlP2Xct5XK/q15Hd4AXqf6KjWb/HzwEW8nMksSfo8FMhIxywsS4f5Lw88aoFNjDzn4sHTb7tSaJOG/0h/jE0tW0Mw==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
  • Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
  • Delivery-date: Mon, 05 Oct 2026 20:05:49 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHdO5mkZaB4SEWRjUSJMpU0C1g6K7bvkooA
  • Thread-topic: [PATCH 4/4] x86/kexec: address Misra rule 11.1 violation in machine_kexec_load()


On 9/3/26 14:44, Jan Beulich wrote:
> Misra rule 11.1 demands no conversion to different types at all. We
> deviate conversions to long, unsigned long, and void *, though - leverage
> that deviation here.
> 
> No functional change intended.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> --- a/xen/arch/x86/machine_kexec.c
> +++ b/xen/arch/x86/machine_kexec.c
> @@ -121,7 +121,8 @@ int machine_kexec_load(struct kexec_imag
>       }
>   
>       code_page = __map_domain_page(image->control_code_page);
> -    memcpy(code_page, kexec_reloc, kexec_reloc_end - (char *)kexec_reloc);
> +    memcpy(code_page, kexec_reloc,
> +           kexec_reloc_end - (const char *)(unsigned long)kexec_reloc);
>       unmap_domain_page(code_page);
>   
>       /*

Reviewed-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>

BR, Dmytro.

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.