[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/PVH: correct PVH Dom0 E820 region merge



On Mon, Oct 05, 2026 at 06:01:34PM +0200, Jan Beulich wrote:
> Folding with an immediately successive region can't be done by merely
> lowering the start of the region. The size of the region needs increasing
> as well.
> 
> Fixes: 5427134eae81 ("x86: populate PVHv2 Dom0 physical memory map")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

My bad...

Reviewed-by: Roger Pau Monné <roger@xxxxxxxxxxxxxx>

> 
> --- a/xen/arch/x86/hvm/dom0_build.c
> +++ b/xen/arch/x86/hvm/dom0_build.c
> @@ -229,6 +229,7 @@ static int __init pvh_add_mem_range(stru
>          if ( rs == e && d->arch.e820[i].type == type )
>          {
>              d->arch.e820[i].addr = s;
> +            d->arch.e820[i].size += e - s;

I think it would be simpler as:

d->arch.e820[i].size = re - s;

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.