Re: [PATCH v3 01/39] xen/riscv: drop INSN_{16,32}BIT_MASK and report unknown instruction lengths

[Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>]

On Wed, 30 Sep 2026 18:18:43 +0200, Oleksii Kurochko 
<oleksii.kurochko@xxxxxxxxx> wrote:
> Both constants were inherited from OpenSBI and their names are misleading.
> The length of an instruction is encoded in its low bits: bits[1:0] != 11
> means 16 bits, otherwise bits[4:2] != 111 means 32 bits, and anything else
> is 48 bits or wider. 0x3 and 0x1c are the patterns compared against in
> these two tests, not masks selecting a 16-bit or a 32-bit instruction. As
> each constant is needed in one place only, once INSN_IS_16BIT() and
> INSN_IS_32BIT() encapsulate the tests, drop them and spell the values out
> in those two macros instead.
> 
> [...]

Reviewed-by: Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>

-- 
Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>