[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RESEND PATCH v1] xen/xsm: flask: restore sidtab state on policy load failure
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>
- Date: Fri, 2 Oct 2026 10:29:58 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tLrSnB8SPF/okncHWoV+okSYAdNqsGAHwI46xiRzM7w=; b=OYCMUUDjy/w4/J7ApYj+wb4i0ft9Vdk8x50Q1d8Rm9Ew9dN3lY98dEHQaA2gqsHwBN9NINNZYATF6S0G/RGZuL5LSz4faNk7beFsDAabyQRUUPfPHXfxuILpKFkNHi71sWJKgHfuZxXpkM0PnXtU0AhbAMJ8SSrk5jSfZAUD/1wJ2aNPXj+VTAnD0QY8ZL+W4stWo2r4e5H3ZjIbFuzW9VBwV2YsG7a/Kcj9ovb2QMAAlqPQTG8u0eJPq9Mn5GDvqXAzF+avSC1lGIasnInFC+SdmL/SJgxGB5AqPRJPEJeHpXqMz2oMKxvh0y6eSEgsQH76yolF/yGVFQQPdH8aTg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rjXTNa4tmxUUGyvJnVmzH6ENDCfx2NyQ43RTQJLSJnVcaW342Z26cThwv+3HDNVJLMmJ1QLU30nVwBP4bRU/QEudNzblMyWkH7KxCjwClsAcVB2SGXzZKedB3poLfsMOoTDklmNjsRnGe0COMwrCSU4SiNz9/JljHbEvzppcFqSAC5Vm9wGHA/CZebkqbtR5nGQzgXR0A44bLhlPT6VzfQRMgzatox8lK23IQF4CVOaud+nQX3Y7pO55/pmk93mCjnBJkk9aVyM/J9fU794y1iwEIVVjrOo7VhCeao3cuiAHHDdOIgV6/1GksG7l8/uhYoM+PG4zFXtq7zko9OeKbQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 02 Oct 2026 10:30:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHdUlATCy0sfywDV06Ga65AkQTQHLbp/b0AgAAPk4A=
- Thread-topic: [RESEND PATCH v1] xen/xsm: flask: restore sidtab state on policy load failure
On 10/2/26 12:34, Jan Beulich wrote:
> On 02.10.2026 11:26, Sergiy Kibrik wrote:
>> Error path of failed sidtab_map() leaves global sidtab in shutdown state and
>> from that point system is unable to allocate new SIDs in
>> sidtab_context_to_sid().
>> To restore sidtab state new function sidtab_activate() is introduced, which
>> only
>> resets shutdown flag, rewinding effect of sidtab_shutdown().
>>
>> Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>
>> ---
>> New function is not strictly required, this also can be achieved just by
>> doing sidtab_set(&sidtab, &sidtab), but this way we would rely on its
>> undocumented internal behaviour.
>> ---
>> xen/xsm/flask/ss/services.c | 1 +
>> xen/xsm/flask/ss/sidtab.c | 7 +++++++
>> xen/xsm/flask/ss/sidtab.h | 1 +
>> 3 files changed, 9 insertions(+)
>
> Nothing is being said as to the reason of this resend. Was this perhaps meant
> to be a ping?
>
yes, it's kind of a ping. No comments for prev patch, so I'm sending
once more, in case it was lost.
-Sergiy
|