[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/ioreq: drop the emulator reference when range set allocation fails
- To: "Edgar E. Iglesias" <edgar.iglesias@xxxxxxx>
- From: Mykola Kvach <xakep.amatop@xxxxxxxxx>
- Date: Tue, 29 Sep 2026 21:47:22 +0300
- Arc-authentication-results: i=1; mx.google.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Ib0bYDqSItM8q5zF2oSJMETpGHQoRqwtaE6dD/u7iD4=; fh=DRIV/2QV7TrPZJXhEwETnDBVA3dZxdD9Slb8lfIc20M=; b=owrhrExY3+mhbUv/nEI4Xq4biLfJCxPd6+T7Atdo5mbLezGx6CyRRVAsybHifILBLO JcldoxWiDF2xw44Tnwrvb9CmennV0bLKAPKYU35a+1QeJUmgyOnliH9gnoil1vFR4OXl H1V2pcsLDDwdY0WIS6c6Rj7R5+MmPP4rewAd/stFHJs143aDVxEuCFmpsX+YUtAZFZo6 7/FYKZQCVJ0aJvYzeNIdK4/5NjvZcKXGYgQ0Yugjc7er7psIyxoBEafLD2xizjALd4l/ NgP5/UoCFH3MJkg6txpL2TiAzp5dKeSMXWblSdA3XCp1iCF9nM82hPU4RikLex4fEJpX uroQ==; darn=lists.xenproject.org
- Arc-seal: i=1; a=rsa-sha256; t=1790707653; cv=none; d=google.com; s=arc-20260327; b=Bt9YE0YsgC7KohBqhnfpO3jCl4HdW9/6b72uabyUzOZ6DuGJdP1hpbGekDnkj8kQa5 glFmwKokBbyrYCkVGurDWC3ThpeRPLJZToYeSjKLKJKMTpjnRfyJ2/HNJue0O55GSeB9 SKhHpAMgE9iGfmfX+NWddsQjI1E75+lH+8QjInPLJR/SbZocmunlL34U5MFKDBI5ab1G jSUlPHhvNZx1lTC9CtBPvuS6BTmhkJclgASFrvEnYwXqMixgYkQTbnmBzh2nK9k0iVbq MkORbMERibJcw5edv88FpO3MnXc4SLu7Z0zUzh3klbv3aRgSCF7r/fwI93V68SB37fCl h4yw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version"
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
- Delivery-date: Tue, 29 Sep 2026 18:47:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Edgar,
Thank you for the patch.
Reviewed-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
Best regards,
Mykola
On Tue, Sep 29, 2026 at 8:57 PM Edgar E. Iglesias
<edgar.iglesias@xxxxxxx> wrote:
>
> ioreq_server_init() takes a reference on the emulating domain before
> allocating the server's range sets, but does not release it when that
> allocation fails. The leaked reference prevents the emulating domain
> from ever being fully destroyed.
>
> Route this failure through the existing put_domain() cleanup.
>
> Fixes: ccb42e0ca661 ("x86/hvm: take a reference on ioreq server emulating
> domain")
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xxxxxxx>
> ---
> xen/common/ioreq.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/xen/common/ioreq.c b/xen/common/ioreq.c
> index f5fd30ce12..4b321a5c61 100644
> --- a/xen/common/ioreq.c
> +++ b/xen/common/ioreq.c
> @@ -595,7 +595,7 @@ static int ioreq_server_init(struct ioreq_server *s,
>
> rc = ioreq_server_alloc_rangesets(s, id);
> if ( rc )
> - return rc;
> + goto fail_rangesets;
>
> s->bufioreq_handling = bufioreq_handling;
>
> @@ -614,6 +614,7 @@ static int ioreq_server_init(struct ioreq_server *s,
>
> ioreq_server_free_rangesets(s);
>
> + fail_rangesets:
> put_domain(s->emulator);
> return rc;
> }
>
> base-commit: 24bd190cd99447ec634da6cb56590ccf44ad627d
> --
> 2.47.3
>
>
|
