Re: [PATCH 5/6] x86/pass-through: use simpler locking primitives in pt_irq_{create,destroy}_bind()

[Roger Pau Monné <roger@xxxxxxxxxxxxxx>]

On Tue, Sep 08, 2026 at 03:03:45PM +0200, Jan Beulich wrote:
> Both functions already assume IRQs to be enabled upon entry, by e.g. their
> acquiring of the domain's event channel lock. Hence like e.g.
> hvm_migrate_pirq() (also called from here) does, saving/restoring of
> EFLAGS.IF isn't necessary (because of the functions called, we can't
> really avoid the saving there).

To clarify this expectation (as code moves around and changes), I
would introduce an explicit ASSERT() that interrupts are enabled.

> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Preferably with the above:

Acked-by: Roger Pau Monné <roger@xxxxxxxxxxxxxx>

Thanks, Roger.