[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] gic: Replace BUG() with ASSERT_UNREACHABLE() in LPI paths
- To: "Orzel, Michal" <michal.orzel@xxxxxxx>
- From: Mykola Kvach <xakep.amatop@xxxxxxxxx>
- Date: Wed, 23 Sep 2026 23:14:46 +0300
- Arc-authentication-results: i=1; mx.google.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=310ddxPyQ67CdOkKBpra+N+cJtSwigrefj3YJxWCnWk=; fh=iHb7RP+hgXFgvYb7euIDLHwm1Ntj6lTjth0e/S9Xdj8=; b=Xa6Xw4MTKC9uKOLVW2L3J6kZwyrDoHRq9mZ1XbkY16iwMiy4EDabuMJABe5Zoay4YH 989fUGweSnda/U4pYx51LMUmPxbEZ7hbCUBm4Qc1BXLTLoJrIepgpJWscss5Z4OobNVB feMwo783oft+Jhw4HiIwLIAhr04JVuzGcaUsIFroBCwhJJVYTViaE3Tq1QzXy2mK09HM K/aLSGy7NNeIdubK7+QBn/E2OQmNKIUhEyYCm3i+eiH3jvXnspgG2fXGcpaLjO7guqzs B/nDO+VZuvb0mICPhETubBHURWivELeELuKoBo9779/AXSQgs2dgYBwK5kXVLsNNkm0c nUxw==; darn=lists.xenproject.org
- Arc-seal: i=1; a=rsa-sha256; t=1790194498; cv=none; d=google.com; s=arc-20260327; b=UR9hEXeUm5vLqFHPKxBYmOjex8zylPzn6d8GDa69uMkzL660DhkpIR+vnbn43XVkiK sKGNI4Tet1ksY3DJOQrb77Q/zNn0cbUg/9/csC+mhrT8/thNicYQLXcE9HBMLipdlUFl Ud8GLaFl+rmDtczJX8R5pEtNvPk0VjI4xQ7Lv3cxWTf1DVPr8YRnkntG2lsINOkDWyw6 dhx00lzYXXTQjbzSZIZLFeIq6JygNf9bnF+8samX8a8dNy07FSx0VzHiCSJeRQL3OVa7 W7+lI+SgqU39ySpaVoIBSRjgdd02seodZ3A3xupBvswYYmtr8gzbQTJTja1HUT2MxVDf voDA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version"
- Cc: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 23 Sep 2026 20:15:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Dec 16, 2025 at 10:57 AM Orzel, Michal <michal.orzel@xxxxxxx> wrote:
>
>
>
> On 16/12/2025 09:22, Dmytro Prokopchuk1 wrote:
> > MISRA C Rule 2.1 states: "A project shall not contain unreachable code."
> > The GIC LPI driver callbacks violate this due to the use of the BUG()
> > macro, which causes the function to never return.
> >
> > Swap BUG() for ASSERT_UNREACHABLE() to satisfy the rule without needing
> > an additional deviation.
> >
> > Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
Reviewed-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
Best regards,
Mykola
|