[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 031/114] tcg: fix off-by-one in helper extend-free assert
- To: qemu-devel@xxxxxxxxxx
- From: Yonggang Luo <luoyonggang@xxxxxxxxx>
- Date: Wed, 23 Sep 2026 21:15:05 +0800
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From"
- Cc: Cornelia Huck <cohuck@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Chao Liu <chao.liu@xxxxxxxxxxxxxxxxxx>, Igor Mammedov <imammedo@xxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Daniel Henrique Barboza <daniel.barboza@xxxxxxxxxxxxxxxx>, Peter Xu <peterx@xxxxxxxxxx>, Eric Blake <eblake@xxxxxxxxxx>, Philippe Mathieu-Daudé <philmd@xxxxxxxxxxxxxxxx>, Liu Zhiwei <zhiwei_liu@xxxxxxxxxxxxxxxxx>, Pierrick Bouvier <pierrick.bouvier@xxxxxxxxxxxxxxxx>, Peter Maydell <peter.maydell@xxxxxxxxxx>, Sunil V L <sunilvl@xxxxxxxxxxxxxxxx>, Stefan Hajnoczi <stefanha@xxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Fabiano Rosas <farosas@xxxxxxx>, Xianglai Li <lixianglai@xxxxxxxxxxx>, Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, qemu-ppc@xxxxxxxxxx, Zhao Liu <zhao1.liu@xxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Bibo Mao <maobibo@xxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Laurent Vivier <laurent@xxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Daniel P. Berrangé <berrange@xxxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, qemu-riscv@xxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxx>, Alex Bennée <alex.bennee@xxxxxxxxxx>, Stafford Horne <shorne@xxxxxxxxx>, Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>, Markus Armbruster <armbru@xxxxxxxxxx>, Weiwei Li <liwei1518@xxxxxxxxx>, Song Gao <17746591750@xxxxxxx>, qemu-arm@xxxxxxxxxx, qemu-s390x@xxxxxxxxxx, Brian Cain <brian.cain@xxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 23 Sep 2026 13:22:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Allow n_extend == MAX_CALL_IARGS after filling extend_free.
- The old < check fired on a valid seven-argument extend.
Signed-off-by: Yonggang Luo <luoyonggang@xxxxxxxxx>
---
tcg/tcg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index 489df0e7386..6d55cc284df 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -2599,7 +2599,7 @@ static void tcg_gen_callN(void *func, TCGHelperInfo *info,
QTAILQ_INSERT_TAIL(&tcg_ctx->ops, op, link);
}
- tcg_debug_assert(n_extend < ARRAY_SIZE(extend_free));
+ tcg_debug_assert(n_extend <= ARRAY_SIZE(extend_free));
for (i = 0; i < n_extend; ++i) {
tcg_temp_free_i64(extend_free[i]);
}
--
2.52.0.windows.1
|