[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/14] crypto/vmac: don't cast away const-ness in aes_key_setup()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Date: Tue, 22 Sep 2026 01:47:21 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ABjxkqnr7LrSZ7UP9i5GI6jpB4IZ0Q931uLfva6gBHU=; b=y95KIFS5i9f1kzH0Y0mNkl1nLU+6h6YnNxiUHgpMLxcW+YAh0XDfQZplV6AacKMaqzPLCqCIRKLvEptX3rX8ls9go0P4jmJv7LX1hfPoG6U/5SJ09cG17LyNmeujia0SV03ZuqBrQDDxZ1Dk8HcZBcK2MjyzYMjdcDDY0cIlhLlzExCM1T0vPwYgFG8oMhULkGa2bfpjrPzmWeI0rJDndIqJryUtLa7GoUjSLfB517JnnF8y2jRheDgkd2qzatjynfiSJShAEUfLMcoKFV4cI/UD+PFT/Y1hB8pSWYz0HV76R7gRsw8Xjw7/sgtyy9E9+Gar51UqxcGJMCX06ZpFXQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CcqhSefTJ8UTG5UEu4NrlEHR/1RPImnioC3u1El6JsiYk2hCsgALmn3yfIeu6sXSykj9R4PEnXo8reRRqsAf7fk+fnehLeKN7g5cvKnLuZeZoO9UJWqxbSnAlA1sxwiF43uEb9OAI5sOzfSftz/gWsDc4KHrVvzwE161xZnZ2u0s47Rm5oAhOWGVQAhZ6t6H410fdzGOxfmor4gmYf8vyo8I+0JtdaZ4J30Nrdl/hL5m4cQHqon5O1Ve0xfqIto0KslNUpibPsR+Xj2x08nWPREqCTvZLo/fdpoQG6rguTn4PzipZyp8RmoMyLnccqjbEWt+FGwaTlstf/jn46pzsw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>
- Delivery-date: Tue, 22 Sep 2026 01:47:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHdOqU/WljR8KEAWECIzLfq3OQ1uQ==
- Thread-topic: [PATCH 11/14] crypto/vmac: don't cast away const-ness in aes_key_setup()
Jan Beulich <jbeulich@xxxxxxxx> writes:
> vmac_set_key() passes in a pointer-to-const, which has const-ness removed
> despite rijndaelKeySetupEnc() properly taking pointer-to-const.
>
> No functional change.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
> ---
> I was wondering whether I shouldn't adjust the adjacent aes_encryption()
> right away as well.
>
> --- a/xen/include/crypto/vmac.h
> +++ b/xen/include/crypto/vmac.h
> @@ -69,7 +69,7 @@ typedef u32 aes_int_key[4*(VMAC_KEY_LEN/
> (u8 *)(in), (u8 *)(out))
> #define aes_key_setup(user_key,int_key) \
> rijndaelKeySetupEnc((u32 *)(int_key), \
> - (u8 *)(user_key), \
> + (const u8 *)(user_key), \
> VMAC_KEY_LEN)
> #endif
>
--
WBR, Volodymyr
|
