[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/14] ACPI: address a Misra rule 11.8 violation in Arm code
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Date: Tue, 22 Sep 2026 01:38:49 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CsMUKnh3vh9o89yTEYUUhLjALRKkl1FwoelPpntop3g=; b=pRP5OrXrYOk+6yDbosOiDBqYfmY2nR4gxJlKOTY47dfg8nAdST6qgrdsxaXm7xWcuwgStTRMNnxFWsqLBSKZDuD77WDIo5diXjLlXEW0IsnUyDWuw8v+ueXKhi2VLuwp+4wzXSc6+5cvlHc0sLCunUU0RxNuY7OnKakjX4fvQ5J4xpymkZBzz8jJgtrCFnOln7Y6BoAjKsuNXP5xUj8/aTnfzyDHeLtCvUzbT+EXcV9THiFDQGLB20J8nv+aFxtSycz6LrcA0QE9aSonkJkpGH8/hxMIZbzPZvPC9x69oRWM6SNx7kppLGJ/CQldw3CdQqC8EgxARt/XWznG6HxdUQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ke65qUcf3o2jVUC/74NBANBgtqwHL6SWTn8Bxoo5+HZ/WN6WX3/U1f3oD4xCs3LQfa6vwVBimby72KWg383IPnBkRYGYvoWMOcc1CviaOf5uH/r/Tn94s7HA6rHwq0gjwAIGhBhtP+baE+50m77m244VXzcZN+YQE+ZMkzpDmZt0t0nl1QyqFYFMkl/IhkYrGgEZrZzBXXBPeDgvSfjRb8TdLdfTEE4siBXgnAp4G+TbAGbKr8cRUNwsIOlZ1tRpvdoeA8F9HBSH+SOBMxeK373i8Ikp9zq/Usw0yUmvboW3fg/jDLOVCrrue+ZTJzT0QpUwPgj0ENfs3gmj/Krc7g==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>
- Delivery-date: Tue, 22 Sep 2026 01:38:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHdOqUePUfY0zBPU0K0F/hx5odMHA==
- Thread-topic: [PATCH 09/14] ACPI: address a Misra rule 11.8 violation in Arm code
Hi Jan,
Jan Beulich <jbeulich@xxxxxxxx> writes:
> Outside of drivers/acpi/tables/ (which is excluded from Eclair reporting
> for dubious reasons), arch/arm/acpi/domain_build.c is the only user of
> ACPI_COMPARE_NAME(). Make the macro const correct, at the expense of
> introducing a "const" variant of ACPI_CAST_PTR(), and at the expense of
I think you can avoid adding ACPI_CAST_PTR() by providing a const
type. Like this:
+#define ACPI_COMPARE_NAME(a, b) (*ACPI_CAST_PTR (const u32, a) == \
+ *ACPI_CAST_PTR (const u32, b))
> altering an imported file.
>
> No functional change intended.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> --- a/xen/include/acpi/acmacros.h
> +++ b/xen/include/acpi/acmacros.h
> @@ -103,6 +103,7 @@
> * Pointer manipulation
> */
> #define ACPI_CAST_PTR(t, p) ((t *) (acpi_uintptr_t) (p))
> +#define ACPI_CAST_CPTR(t, p) ((const t *) (const acpi_uintptr_t)
> (p))
> #define ACPI_CAST_INDIRECT_PTR(t, p) ((t **) (acpi_uintptr_t) (p))
> #define ACPI_ADD_PTR(t,a,b) ACPI_CAST_PTR (t, (ACPI_CAST_PTR
> (u8,(a)) + (acpi_native_uint)(b)))
> #define ACPI_PTR_DIFF(a,b) (acpi_native_uint) (ACPI_CAST_PTR
> (u8,(a)) - ACPI_CAST_PTR (u8,(b)))
> @@ -116,9 +117,12 @@
> #define ACPI_PTR_TO_PHYSADDR(i) ACPI_TO_INTEGER(i)
>
> #ifndef ACPI_MISALIGNMENT_NOT_SUPPORTED
> -#define ACPI_COMPARE_NAME(a,b) (*ACPI_CAST_PTR (u32,(a)) ==
> *ACPI_CAST_PTR (u32,(b)))
> +#define ACPI_COMPARE_NAME(a, b) (*ACPI_CAST_CPTR (u32, a) == \
> + *ACPI_CAST_CPTR (u32, b))
> #else
> -#define ACPI_COMPARE_NAME(a,b) (!ACPI_STRNCMP (ACPI_CAST_PTR
> (char,(a)), ACPI_CAST_PTR (char,(b)), ACPI_NAME_SIZE))
> +#define ACPI_COMPARE_NAME(a, b) (!ACPI_STRNCMP (ACPI_CAST_CPTR
> (char, a), \
> + ACPI_CAST_CPTR
> (char, b), \
> + ACPI_NAME_SIZE))
> #endif
>
> /*
--
WBR, Volodymyr
|
