[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/vpmu: Fix incorrect printk format specifiers
- To: "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Alejandro Vallejo" <alejandro.garciavallejo@xxxxxxx>
- Date: Mon, 21 Sep 2026 19:31:34 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qT6YvApqICwnus4uJaLBtTpqiU9RiIFrSXWT8PiYie0=; b=jxZRLmdle+Z6qSptGYIETFQbqOqMhTZtUmLU5YU1Vg90K68KmU9fHhYWnKirXF/hSmMKI2v1u6LZ2oi/onp8lQXMjo9CD0NVmOWJLgv8l3Rny6HR26Bhp2v6JtZjGb4nLrqwhUiVQDD7izh4fiBalMFF0uky4rg+PEoMklYho64A+a4PYGl3Ho0/efe6UwbDgPC/7Ujx39HQN4++OxqbtmAwQimf+2/u8qV60uCmH1AB0DQlpZiXOv4K2F1AkzacxcR+ELpSaY/UeXqIYPW+1GDVJPT6pUvUT57UxU46WN0M5zo9ljRVkNQ51p2ytQpCbW/jcELG3YUiygFjNkECww==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Oc8CxIFP16jmiHSJ6EqHK1JMJbjRZJIS8OepnxKDxowtD4ibJTnU9wzW7Lvdk2pTZIOoJ/Cwnj9toPXPYjx5VNMa4RSfIVCqqJRxQ8NvUYDcNO/OxuuxP3u6cb3uyjIIPuvuIqh8xSTuYKpMmUAQjdbYf4vltzms89EIavHi93GkviDasmUXUm+MjAK4R5JhyVf7R9ul5Jo4TsjC3JXPO5B8EzZAqgZysQmNDfY66OJY9O4xuLKTbJEM0jVIlRTzagRgEwGVmVE8s4xtOJQ1RqQwOLhfgrDww/dI+SUCA6l2VynsM3bq4Y/GOpRN31JtSbfi4xTqpL7zu7qs+1Z8tw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-Id:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Jan Beulich" <jbeulich@xxxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, "Teddy Astie" <teddy.astie@xxxxxxxxxx>
- Delivery-date: Mon, 21 Sep 2026 17:31:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon Sep 21, 2026 at 5:59 PM CEST, Andrew Cooper wrote:
> On 21/09/2026 11:33 am, Alejandro Vallejo wrote:
> > On Mon Sep 21, 2026 at 11:30 AM CEST, Andrew Cooper wrote:
> >> On 21/09/2026 10:16 am, Alejandro Vallejo wrote:
> >>> The patch in Fixes adjusted two vendor variables from uint8_t and plain
> >>> int to to unsigned int. But they were both used later in printks with
> >>> the %d specifier rather than %u. Adjust accordingly.
> >>>
> >>> Fixes: 39a9a49449d7 ("x86: Remove x86 prefixed names from x86/cpu/ files")
> >>> Signed-off-by: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
> >> If this is going to be a problem, then shouldn't we turn
> >> -Wformat-signedness on?
> > I tried that before sending, but that needs a whole new series. Things
> > are not quite as clean as I'd hope.
>
> Well, it's going to keep on regressing until -Wformat-signedness is in
> place.
>
> ~Andrew
In case it wasn't obvious, I agree. I just happened to bump into these
while refactoring that general area for another series and I'd rather
fix them separately rather than bundling it in a 15+ patch series.
In due course it shall be done.
Cheers,
Alejandro
|
