[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/2] drm/imx: replace struct drm_simple_display_pipe with regular atomic helpers
- To: "Maxime Ripard" <mripard@xxxxxxxxxx>, "Thomas Zimmermann" <tzimmermann@xxxxxxx>
- From: "Ze Huang" <ze.huang@xxxxxxxxxxxxxxxx>
- Date: Sat, 19 Sep 2026 01:05:13 +0800
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=qcppdkim1 header.d=qualcomm.com header.i="@qualcomm.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-Id:Mime-Version:References:Subject:To"; dkim=pass header.s=google header.d=oss.qualcomm.com header.i="@oss.qualcomm.com" header.h="In-Reply-To:References:To:From:Subject:Cc:Message-Id:Date:Content-Type:Content-Transfer-Encoding:Mime-Version"
- Cc: "Ze Huang" <ze.huang@xxxxxxxxxxxxxxxx>, "Alexey Brodkin" <abrodkin@xxxxxxxxxxxx>, "Maarten Lankhorst" <maarten.lankhorst@xxxxxxxxxxxxxxx>, "David Airlie" <airlied@xxxxxxxxx>, "Simona Vetter" <simona@xxxxxxxx>, "Joel Stanley" <joel@xxxxxxxxx>, "Andrew Jeffery" <andrew@xxxxxxxxxxxxxxxxxxxx>, "Frank Li" <Frank.Li@xxxxxxx>, "Sascha Hauer" <s.hauer@xxxxxxxxxxxxxx>, "Pengutronix Kernel Team" <kernel@xxxxxxxxxxxxxx>, "Fabio Estevam" <festevam@xxxxxxxxx>, "Linus Walleij" <linusw@xxxxxxxxxx>, "Hans de Goede" <hansg@xxxxxxxxxx>, "Alex Lanzano" <lanzano.alex@xxxxxxxxx>, "Oleksandr Andrushchenko" <oleksandr_andrushchenko@xxxxxxxx>, "Philipp Zabel" <p.zabel@xxxxxxxxxxxxxx>, Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>, "Marian Cichy" <m.cichy@xxxxxxxxxxxxxx>, <dri-devel@xxxxxxxxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <linux-aspeed@xxxxxxxxxxxxxxxx>, <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, <imx@xxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 18 Sep 2026 17:05:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed Sep 16, 2026 at 3:46 PM CST, Maxime Ripard wrote:
> On Wed, Sep 16, 2026 at 08:50:21AM +0200, Thomas Zimmermann wrote:
>> > +static const struct drm_plane_funcs imx_lcdc_plane_funcs = {
>> > + .update_plane = drm_atomic_helper_update_plane,
>> > + .disable_plane = drm_atomic_helper_disable_plane,
>> > + .destroy = drm_plane_cleanup,
>> > + .reset = drm_atomic_helper_plane_reset,
>
> Also, this needs to be drm_atomic_helper_plane_create_state
>
>> > +static const struct drm_crtc_funcs imx_lcdc_crtc_funcs = {
>> > + .reset = drm_atomic_helper_crtc_reset,
>
> and drm_atomic_helper_crtc_create_state
>
> Maxime
Thanks for the reminder. Will do.
Ze
|
