[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC v3 06/13] bpf: Take a Tasks Trace reader in the trampoline glue
- To: "Josef Bacik" <josef@xxxxxxxxxxxxxx>, "Paul E. McKenney" <paulmck@xxxxxxxxxx>, "Frederic Weisbecker" <frederic@xxxxxxxxxx>, "Neeraj Upadhyay" <neeraj.upadhyay@xxxxxxxxxx>, "Joel Fernandes" <joelagnelf@xxxxxxxxxx>, "Boqun Feng" <boqun@xxxxxxxxxx>, "Thomas Gleixner" <tglx@xxxxxxxxxx>, "Peter Zijlstra" <peterz@xxxxxxxxxxxxx>, "Steven Rostedt" <rostedt@xxxxxxxxxxx>, "Masami Hiramatsu" <mhiramat@xxxxxxxxxx>, "Mark Rutland" <mark.rutland@xxxxxxx>, "Jiri Olsa" <jolsa@xxxxxxxxxx>, "Alexei Starovoitov" <ast@xxxxxxxxxx>, "Daniel Borkmann" <daniel@xxxxxxxxxxxxx>, "Andrii Nakryiko" <andrii@xxxxxxxxxx>, <x86@xxxxxxxxxx>, "Catalin Marinas" <catalin.marinas@xxxxxxx>, "Will Deacon" <will@xxxxxxxxxx>, "Puranjay Mohan" <puranjay@xxxxxxxxxx>, "Xu Kuohai" <xukuohai@xxxxxxxxxxxxxxx>, "Paul E. McKenney" <paulmck@xxxxxxxxxx>, "Frederic Weisbecker" <frederic@xxxxxxxxxx>, "Neeraj Upadhyay" <neeraj.upadhyay@xxxxxxxxxx>, "Joel Fernandes" <joelagnelf@xxxxxxxxxx>, "Boqun Feng" <boqun@xxxxxxxxxx>, "Thomas Gleixner" <tglx@xxxxxxxxxx>, "Peter Zijlstra" <peterz@xxxxxxxxxxxxx>, "Steven Rostedt" <rostedt@xxxxxxxxxxx>, "Masami Hiramatsu" <mhiramat@xxxxxxxxxx>, "Mark Rutland" <mark.rutland@xxxxxxx>, "Jiri Olsa" <jolsa@xxxxxxxxxx>, "Alexei Starovoitov" <ast@xxxxxxxxxx>, "Daniel Borkmann" <daniel@xxxxxxxxxxxxx>, "Andrii Nakryiko" <andrii@xxxxxxxxxx>, <x86@xxxxxxxxxx>, "Catalin Marinas" <catalin.marinas@xxxxxxx>, "Will Deacon" <will@xxxxxxxxxx>, "Puranjay Mohan" <puranjay@xxxxxxxxxx>, "Xu Kuohai" <xukuohai@xxxxxxxxxxxxxxx>
- From: "Alexei Starovoitov" <alexei.starovoitov@xxxxxxxxx>
- Date: Wed, 16 Sep 2026 03:45:16 +0000
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="In-Reply-To:References:To:From:Subject:Cc:Message-Id:Date:Content-Type:Content-Transfer-Encoding:Mime-Version"
- Cc: "Andy Lutomirski" <luto@xxxxxxxxxx>, "Josh Triplett" <josh@xxxxxxxxxxxxxxxx>, "Uladzislau Rezki" <urezki@xxxxxxxxx>, "Mathieu Desnoyers" <mathieu.desnoyers@xxxxxxxxxxxx>, "Lai Jiangshan" <jiangshanlai@xxxxxxxxx>, "Zqiang" <qiang.zhang@xxxxxxxxx>, "Juergen Gross" <jgross@xxxxxxxx>, "Luis Chamberlain" <mcgrof@xxxxxxxxxx>, "Ihor Solodrai" <ihor.solodrai@xxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <rcu@xxxxxxxxxxxxxxx>, <linux-trace-kernel@xxxxxxxxxxxxxxx>, <bpf@xxxxxxxxxxxxxxx>, <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andy Lutomirski" <luto@xxxxxxxxxx>, "Josh Triplett" <josh@xxxxxxxxxxxxxxxx>, "Uladzislau Rezki" <urezki@xxxxxxxxx>, "Mathieu Desnoyers" <mathieu.desnoyers@xxxxxxxxxxxx>, "Lai Jiangshan" <jiangshanlai@xxxxxxxxx>, "Zqiang" <qiang.zhang@xxxxxxxxx>, "Juergen Gross" <jgross@xxxxxxxx>, "Luis Chamberlain" <mcgrof@xxxxxxxxxx>, "Ihor Solodrai" <ihor.solodrai@xxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <rcu@xxxxxxxxxxxxxxx>, <linux-trace-kernel@xxxxxxxxxxxxxxx>, <bpf@xxxxxxxxxxxxxxx>, <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 16 Sep 2026 03:45:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue Sep 15, 2026 at 1:17 PM UTC, Josef Bacik wrote:
> +static __always_inline void bpf_tramp_read_lock_trace(void)
> +{
> + if (IS_ENABLED(CONFIG_TASKS_RCU_TRAMPOLINE_READERS))
> + rcu_read_lock_trace();
> +}
> +
> +static __always_inline void bpf_tramp_read_unlock_trace(void)
> +{
> + if (IS_ENABLED(CONFIG_TASKS_RCU_TRAMPOLINE_READERS))
> + rcu_read_unlock_trace();
> +}
> +
> +static u64 notrace __rcu_trampoline
> +__bpf_prog_enter_recur(struct bpf_prog *prog, struct bpf_tramp_run_ctx
> *run_ctx)
> __acquires(RCU)
> {
> + bpf_tramp_read_lock_trace();
> rcu_read_lock_dont_migrate();
This is double increment. rcu_read_lock_dont_migrate() includes
rcu_read_lock_trace().
|
