Re: [PATCH Linux v2 7/7] xen: Add new Xen pv-op pte_get_and_clear.

[Jan Beulich <jbeulich@xxxxxxxx>]

On 15.09.2026 19:42, Kevin Lampis wrote:
>>> --- a/arch/x86/include/asm/pgtable.h
>>> +++ b/arch/x86/include/asm/pgtable.h
>>> @@ -58,6 +58,7 @@ extern pmdval_t early_pmd_flags;
>>>   #include <asm/paravirt.h>
>>>   #else  /* !CONFIG_PARAVIRT_XXL */
>>>   #define set_pte(ptep, pte)           native_set_pte(ptep, pte)
>>> +#define pte_get_and_clear(ptep)      native_ptep_get_and_clear(ptep)
>>>  
>>>   #define set_pte_atomic(ptep, pte)                                    \
>>>         native_set_pte_atomic(ptep, pte)
>>> @@ -1243,7 +1244,7 @@ bool ptep_clear_flush_young(struct vm_area_struct 
>>> *vma,
>>>   static inline pte_t ptep_get_and_clear(struct mm_struct *mm, unsigned 
>>> long addr,
>>>                                        pte_t *ptep)
>>>   {
>>> -     pte_t pte = native_ptep_get_and_clear(ptep);
>>> ++    pte_t pte = pte_get_and_clear(ptep);
>>
>> This looks like a typo, on a path you didn't compile.
> 
> I don't understand what you mean here.

There's a stray + at the start of the line (apart from the one that
indicates the inserted line). I think that's what Andrew has tried
to point out.

Jan