[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/7] x86: extend update_intpte() to support atomic get-and-update
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Kevin Lampis <kevin.lampis@xxxxxxxxxx>
- Date: Tue, 15 Sep 2026 17:40:48 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vUrYNOI9r0C0mwIIGWx2ncqfPsgZgCcsFQo4810CMeA=; b=lDMacFVP/DK6JDL9irPgdP5mAuy4tLSLbLFH9QBewVd8CXIToOBLr0eICPTrjJdrWcg/Alsn3dim3dj2f42HrsvtM2V4aM0/0qZ1tO3zSKjsSXJcx/3KIu3yc5lYBt+K/b/diymSrvxWVm+VeOMtNyL0ZFZNu66/rNNv2fqbvyKfgY4BKm9OtORtCRcCB3ZQrMeqwq69mxR636VElUMQQd/PPV1YtRQ+5RZH43zK0VG7/JbnY8mpXBjnjcmnHN6CTol9eCFFVLOoU+M95yF/x7QFTQgjZlPgpLq79wmgIAcU/0qaw6rxxNTbyKElpLQqFIFaKIWgRPKyCYJtJku3Qw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Gqsr7afEe8MXHi4A9Nh+Zmjw+Tg8+nrqfbB41Mg6zzGVPejOnH9MUvQS6PHQWgw5Ir12xnRt6jNxL6HSOUGt/iWHvKYA5sPoQSH/+ssq+m1LzWNR1/BCaPr+XG04lRkoEyqT9YhR1aeUPXGUZVW3iwqM/RN4mosgJFL31DNedrlOUkx5NamAUAtmxqjmRV7dlmCi7NJyUpZsSN+oK7U+9TMaKQxd2qDEg8HP1Wqcxbj7PlRrCnizGh0PdLuBk28u81TeAA+BPEMg4t1cUtTgW8+NtRmWhYQU86D+D3z6p34FTG5FjBt2c05wdvjqKfmR1/a1msWCuoGjYDhLxbHi7A==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, "teddy.astie@xxxxxxxxxx" <teddy.astie@xxxxxxxxxx>
- Delivery-date: Tue, 15 Sep 2026 17:40:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels:
- Thread-index: AQHdQWMYYuOEW7sUTEmdu2MmKUu4LbbJV30AgAaXyo0=
- Thread-topic: [PATCH v2 3/7] x86: extend update_intpte() to support atomic get-and-update
> you want to wrap the expression in _t ## e_from_intpte(...) to
>hand back the type safe version. In turn, this lets you remove the
>'.l1' part of the assignments in the following patch.
That would be much nicer but it trips over `-Werror=unused-value`.
I don't know a way to solve this without adding `(void)UPDATE_ENTRY(...)` to
every call site or doing
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wunused-value"
#define UPDATE_ENTRY(...)
#pragma GCC diagnostic pop
neither of which seems very good.
|
