[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] nestedsvm: Crash domain rather than Xen on unexpected VMEXIT
- To: xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
- Date: Fri, 4 Sep 2026 15:27:57 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WG3EHvt5kN23gToKWT482W/P12w4LccgJjBIvavAw6A=; b=zNnd1M6340bdWGKxi18s4/RGnf+MxPYi51wboiDeP25+l/+zWDp8WrShy89t59YVRf7t/+MO0r00tA97DAZyVDuiE3Av5kjLheZg+i6mWamzdDHmZfvtzN72y/AQzg1rbj+NESDAan7CpI6oy/Dodqr95LvWb6q4XuQ70ufwlh+SUhaXoI55wSJSpg1reAMenm3EEXDV9ePol8agENn+sOw0v+xcUpNH85c0L2A3mxDraY6l4fX5RC/97MMGnZSgwjK/ajfclaB38DA3Gxi2QYUbKkjB508Ub5b3HxJWIyH5SCCpjRY7PXTL/0Qp5AbyTFWLtq/BJ66mDN4w25l3EA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PvFNtMGZklJ052V3U8+H2sCrRAhL+mqdZ8SWpba/WzDyySwnhl0jpbh0gp3BAUmeslYHTGrbzYATX1TEu6k+rMUg+sJJbkb6RFa8QhvNWU+ufyW1lzv3qdk1snwNnyw/bLMDoYVNGFeMaEXaeyboLhVrTcRd5UzAozL7DuuwrKGObhmK3Z4+VoFmj3+8u7ajFfs1bORgnnk+1+lFQU1G7WkOuOUzA1tdVcyRoKdJik5aMYuZvpwAe+Q90nmdYyLj62sNkbU9SqlyN6sQ0MflxwKrT5183dEQK4VqcKru+evC9cE7PDSy2VU4E3Wq+t+iGoQ109JWDdntAcU4Yp50wQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>
- Delivery-date: Fri, 04 Sep 2026 14:28:21 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On encountering an unexpected VMEXIT (e.g. because L1 has used an
intercept that L0 Xen doesn't know about), crash the domain rather than
the hypervisor.
Fixes: 9a779e4fc161 ("Implement SVM specific part for Nested Virtualization")
Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
---
This can be triggered running kvm-unit-tests in L1.
Xen undoubtedly needs to handle the intercepts properly but as a first
step it shouldn't BUG().
xen/arch/x86/hvm/svm/nestedsvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c
index 3d0e77f5eb24..5adb1bd72c4d 100644
--- a/xen/arch/x86/hvm/svm/nestedsvm.c
+++ b/xen/arch/x86/hvm/svm/nestedsvm.c
@@ -923,7 +923,7 @@ nsvm_vmcb_guest_intercepts_exitcode(struct vcpu *v,
default:
gdprintk(XENLOG_ERR, "Illegal exitcode %#"PRIx64"\n", exitcode);
- BUG();
+ domain_crash(v->domain);
break;
}
--
2.53.0
|
