[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 07/39] xen/riscv: add missing APLIC register offsets, masks to asm/aplic.h





On 9/2/26 3:22 PM, Jan Beulich wrote:
On 01.09.2026 17:53, Jan Beulich wrote:
On 01.09.2026 17:36, Baptiste Le Duc wrote:
On Thu, 27 Aug 2026 17:20:51 +0200, Oleksii Kurochko 
<oleksii.kurochko@xxxxxxxxx> wrote:
These definitions are required for correct decoding of APLIC MMIO
accesses and target configuration, and will be used by both the
physical and virtual APLIC implementations.

While adding them, rearrange the header in the style of x86's
asm/msr-index.h: a register's offset is immediately followed by the
definitions of that register's fields, with the blocks sorted by
offset.  This makes the relation between a register and its fields
obvious from the layout alone, so no comment is needed to express it.

[...]

Reviewed-by: Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Thanks.


If there's no dependency on earlier patches (nor the prereq series), this
could go in right away. Yet nothing is being said anywhere, unless I
overlooked anything.

Doesn't apply cleanly to current staging, so left out for the time being.

Yes, it isn't applied because of:

[PATCH v8 12/20] xen/riscv: introduce minimal virtual APLIC (vAPLIC) infrastructure

~ Oleksii



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.